Page MenuHomePhabricator

[web] Hide thread menu for pending threads
ClosedPublic

Authored by jacek on May 19 2022, 8:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 9, 3:49 PM
Unknown Object (File)
Sat, Nov 9, 3:36 PM
Unknown Object (File)
Sat, Nov 9, 3:34 PM
Unknown Object (File)
Sat, Nov 9, 6:19 AM
Unknown Object (File)
Fri, Nov 8, 10:44 PM
Unknown Object (File)
Thu, Nov 7, 9:19 AM
Unknown Object (File)
Thu, Nov 7, 9:19 AM
Unknown Object (File)
Thu, Nov 7, 9:19 AM

Details

Summary

The diff solves the issue:
https://linear.app/comm/issue/ENG-1168/thread-menu-is-available-for-pending-threads-and-crashes-the-app
Is prevents rendering thread menu (the one on the right of top thread bar) when thread is pending.

Test Plan

Create pending sidebar (or thread by writing to the new user). The menu is not displayed now, and it's not possible to crash the app by launching any thread settings modal)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable