[services] Backup - Add Attachment Reactor - read request
AbandonedPublic
Actions

Authored by • karol on May 24 2022, 3:02 AM.

Details

Reviewers

tomek
ashoat

Summary

Depends on D4081

Adding a method for reading requests. Basically it reads all parameters of the attachments from the client.

Test Plan

The backup service can be built successfully.

For the full test plan of this functionality that has been broken into multiple diffs, please see D4090.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.May 24 2022, 3:02 AM

Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptMay 24 2022, 3:02 AM

• karol edited the summary of this revision. (Show Details)May 24 2022, 3:05 AM

• karol added a reviewer: tomek.

• karol added a child revision: D4089: [services] Backup - Add Attachment Reactor - terminate callback.

• karol edited the summary of this revision. (Show Details)May 24 2022, 3:07 AM

• karol added a parent revision: D4081: [services] Backup - Add Attachment Reactor - structure.

• karol edited the summary of this revision. (Show Details)May 24 2022, 3:10 AM

• karol edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B9429: Diff 13055.May 24 2022, 3:24 AM

• karol requested review of this revision.May 24 2022, 3:24 AM

As discussed in the proto diff, this API should not be in the backup service

This revision now requires changes to proceed.May 24 2022, 12:17 PM

• karol abandoned this revision.May 26 2022, 3:04 AM

Revision Contents
Changeset List

Path

Size

services/

backup/

src/

Reactors/

server/

AddAttachmentReactor.cpp

22 lines

Diff 13055

View Options

services/backup/src/Reactors/server/AddAttachmentReactor.cpp

[services] Backup - Add Attachment Reactor - read requestAbandonedPublicActions