Page MenuHomePhabricator
Differential D4114

[CI] Get rid of `touch` JSON commands in CI
ClosedPublic
Actions

Authored by atul on May 24 2022, 6:45 AM.
Tags
None
Referenced Files
F1767396: D4114.diff
Wed, May 15, 5:36 AM
Unknown Object (File)
Fri, May 3, 1:30 PM
Unknown Object (File)
Sun, Apr 28, 4:59 PM
Unknown Object (File)
Mon, Apr 22, 7:46 PM
Unknown Object (File)
Mon, Apr 22, 7:46 PM
Unknown Object (File)
Mon, Apr 22, 7:46 PM
Unknown Object (File)
Mon, Apr 22, 7:46 PM
Unknown Object (File)
Mon, Apr 22, 7:43 PM
View All Files
Subscribers
• abosh
• adrian

Details

Reviewers
ashoat
tomek
• jacek
• benschac
Commits
rCOMM8aea703406b3: [CI] Get rid of `touch` JSON commands in CI
Summary

Linear Issue: https://linear.app/comm/issue/ENG-1190/get-rid-of-touch-json-commands-in-ci

We were previously creating empty JSON files via the touch command to appease flow in the ESLint/Flow/Test workflows on GitHub and Buildkite.

However, we no longer need to do this as of https://phabricator.ashoat.com/D4097.

Test Plan

See if Buildkite CI passes (on arc diff) and if GH Actions CI passes (on arc land)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.May 24 2022, 6:45 AM
Herald added subscribers: • abosh, • adrian. · View Herald TranscriptMay 24 2022, 6:45 AM
atul mentioned this in D4110: [CI] Add `keyserver: yarn test` to CI.May 24 2022, 6:46 AM
atul added inline comments.
.buildkite/eslint_flow_jest.yml
6 ↗(On Diff #13075)

Also snuck in this change to clean things up

Before:

- 'cd lib && yarn test'
- 'cd ../keyserver && yarn test'
Harbormaster completed remote builds in B9439: Diff 13075.May 24 2022, 6:51 AM
atul requested review of this revision.May 24 2022, 6:51 AM
ashoat accepted this revision.May 24 2022, 7:02 AM
This revision is now accepted and ready to land.May 24 2022, 7:02 AM
atul updated this revision to Diff 13079.May 24 2022, 7:16 AM

rebase before landing

Harbormaster completed remote builds in B9442: Diff 13079.May 24 2022, 7:23 AM
Closed by commit rCOMM8aea703406b3: [CI] Get rid of `touch` JSON commands in CI (authored by atul). · Explain WhyMay 24 2022, 7:24 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM8aea703406b3: [CI] Get rid of `touch` JSON commands in CI.

Revision Contents
Changeset List

PathSize
.buildkite/
6 lines
.github/
workflows/
11 lines

Diff 13080

View Options

.buildkite/eslint_flow_jest.yml

Loading...
View Options

.github/workflows/eslint_flow_jest.yml

Loading...