[native] Remove `setThreadStoreLoaded(true)` early return in SQLiteContextProvider
ClosedPublic
Actions

Authored by atul on May 31 2022, 6:03 AM.

Details

Reviewers

• jacek
tomek

Commits

rCOMM02a01cd0f0b7: [native] Remove `setThreadStoreLoaded(true)` early return in…

Summary

This early return was needed before persistConfig.version was bumped to 30 so the migration could be tested in DEV without breaking things for any general releases made before this work was complete.

Since the persistConfig.version has been bumped, there's no possibility that a new client would have a persistConfig.version < 30, so this branch will never be hit.

Test Plan

NA, not sure how to test

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.May 31 2022, 6:03 AM

Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptMay 31 2022, 6:03 AM

Harbormaster completed remote builds in B9537: Diff 13230.May 31 2022, 6:11 AM

atul requested review of this revision.May 31 2022, 6:11 AM

atul added a child revision: D4159: [native] Add `messageStoreLoaded` to `SQLiteContext`.May 31 2022, 6:23 AM

tomek accepted this revision.Jun 1 2022, 7:24 AM

tomek added inline comments.

native/data/sqlite-context-provider.js
35 ↗	(On Diff #13230)	Just to make sure: this is a static, hardcoded value, right? (not something that we read from persisted data)

This revision is now accepted and ready to land.Jun 1 2022, 7:24 AM

atul marked an inline comment as done.Jun 1 2022, 9:07 AM

atul added inline comments.

native/data/sqlite-context-provider.js
35 ↗	(On Diff #13230)	Yup, we're importing `persistConfig` from `../redux/persist`. `persistConfig` looks like the following: of which the `version` property is a static value