Page MenuHomePhabricator
Differential D4168

[services] Tunnelbroker - Fix arguments table format for new amqp queue
ClosedPublic
Actions

Authored by • max on May 31 2022, 12:48 PM.
Tags
None
Referenced Files
F3531255: D4168.diff
Wed, Dec 25, 6:55 AM
Unknown Object (File)
Nov 9 2024, 3:17 AM
Unknown Object (File)
Nov 8 2024, 1:33 AM
Unknown Object (File)
Nov 8 2024, 12:40 AM
Unknown Object (File)
Nov 7 2024, 10:50 PM
Unknown Object (File)
Nov 6 2024, 11:41 AM
Unknown Object (File)
Nov 3 2024, 1:31 PM
Unknown Object (File)
Nov 3 2024, 1:31 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• karol
tomek

Details

Reviewers
• karol
tomek
Commits
rCOMM313a81b1919d: [services] Tunnelbroker - Fix arguments table format for new amqp queue
Summary

This diff fixes the following bug:

When the rabbitMQ queue for the tunnelbroker-id is not created (clean rabbitMQ instance) there is an error when creating a new one:

AMQP: Queue creation error: PRECONDITION_FAILED - inequivalent arg 'x-expires' for queue 'tunnelbroker1' in vhost '/'.

We must remove conversion to the string when initializing the queue attribute. That fixes the error.

Test Plan
  1. On the master branch where rabbitMQ Docker container instance was not initialized before (was clean) run yarn run-tunnelbroker-service-dev-mode and get a queue creation error (which is described above in the diff description).
  1. Apply the diff patch and re-run yarn run-tunnelbroker-service-dev-mode. The rabbitMQ queue will be created successfully.

Diff Detail

Repository
rCOMM Comm
Branch
fix-amqp-queue-arguments-to-int
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• max created this revision.May 31 2022, 12:48 PM
• max held this revision as a draft.
Herald added subscribers: • abosh, • karol, atul and 3 others. · View Herald TranscriptMay 31 2022, 12:48 PM
• max published this revision for review.May 31 2022, 12:50 PM
• max edited the summary of this revision. (Show Details)
• max edited the test plan for this revision. (Show Details)
• max added reviewers: • karol, tomek.
• max added a parent revision: D4149: [services] Remove `networks` from services `docker-compose` file..
Harbormaster completed remote builds in B9561: Diff 13258.May 31 2022, 12:53 PM
• max added a child revision: D3965: [services] Tunnelbroker - Add dynamoDB tables to the Terraform.May 31 2022, 1:01 PM
tomek accepted this revision.Jun 2 2022, 12:53 AM
This revision is now accepted and ready to land.Jun 2 2022, 12:53 AM
• max updated this revision to Diff 13299.Jun 2 2022, 11:28 AM

Rebase on master, remove it from the stack, because it can be landed as an independent diff.

• max removed a parent revision: D4149: [services] Remove `networks` from services `docker-compose` file..Jun 2 2022, 11:29 AM
• max removed a child revision: D3965: [services] Tunnelbroker - Add dynamoDB tables to the Terraform.
Harbormaster completed remote builds in B9589: Diff 13299.Jun 2 2022, 11:40 AM
• max updated this revision to Diff 13302.Jun 2 2022, 12:03 PM

Rebase on master.

Harbormaster completed remote builds in B9592: Diff 13302.Jun 2 2022, 12:14 PM
• max updated this revision to Diff 13308.Jun 2 2022, 12:26 PM

Fixing stack diff commit.

• max added a child revision: D3965: [services] Tunnelbroker - Add dynamoDB tables to the Terraform.Jun 2 2022, 12:49 PM
Harbormaster completed remote builds in B9598: Diff 13308.Jun 2 2022, 12:50 PM
Closed by commit rCOMM313a81b1919d: [services] Tunnelbroker - Fix arguments table format for new amqp queue (authored by • max). · Explain WhyJun 3 2022, 12:19 AM
This revision was automatically updated to reflect the committed changes.
• max added a commit: rCOMM313a81b1919d: [services] Tunnelbroker - Fix arguments table format for new amqp queue.
• max removed a child revision: D3965: [services] Tunnelbroker - Add dynamoDB tables to the Terraform.Jun 3 2022, 12:30 AM

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
src/
Amqp/
4 lines

Diff 13258

View Options

services/tunnelbroker/src/Amqp/AmqpManager.cpp

Loading...