Instead of using messageStore.messages from the previous updatedMessageStore object, we pull messageStore.messages from processedMessageStore.messages instead.
Depends on D4204
Details
Details
This should be a straightforward refactor given we've had assertMessageStoreMessagesAreEqual in place for some time now.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/reducers/message-reducer.js | ||
|---|---|---|
| 1331–1334 ↗ | (On Diff #13321) | |
| lib/reducers/message-reducer.js | ||
|---|---|---|
| 1331–1334 ↗ | (On Diff #13321) | Right now the "ops-approach" only modifies messageStore.messages, we'll need to "get the rest" of the messageStore using the old way |
| lib/reducers/message-reducer.js | ||
|---|---|---|
| 1331–1334 ↗ | (On Diff #13321) | It would be more maintainable if we passed a message store with all the changes to processMessageStoreOperations and directly use the result in return value. |
Comment Actions
It would be more maintainable if we passed a message store with all the changes to processMessageStoreOperations and directly use the result in return value.
That's the goal but it'll be sequenced later in this stack: https://phab.comm.dev/D4201#121744