Page MenuHomePhabricator
Differential D4206

[web] Turn `InvalidUploadModal` into a functional component
ClosedPublic
Actions

Authored by atul on Jun 2 2022, 10:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 4:00 AM
Unknown Object (File)
Sat, Nov 2, 2:52 PM
Unknown Object (File)
Sat, Nov 2, 2:52 PM
Unknown Object (File)
Sat, Nov 2, 2:52 PM
Unknown Object (File)
Sat, Nov 2, 2:52 PM
Unknown Object (File)
Sat, Nov 2, 2:52 PM
Unknown Object (File)
Sat, Nov 2, 2:48 PM
Unknown Object (File)
Oct 24 2024, 11:34 PM
View All Files
Subscribers
• abosh
• adrian
ashoat

Details

Reviewers
tomek
• jacek
Commits
rCOMM9801af9b88c2: [web] Turn `InvalidUploadModal` into a functional component
Summary

Was looking at this as part of the work to create a common Alert/Prompt component and noticed it might as well be a functional component... so made that change.

Test Plan

Dragged a random non-image file into the chat area and the InvalidUploadModal component was displayed as expected:

Screen Shot 2022-06-03 at 1.13.27 AM.png (456×726 px, 33 KB)

Diff Detail

Repository
rCOMM Comm
Branch
landjune4 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jun 2 2022, 10:15 PM
Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptJun 2 2022, 10:15 PM
atul edited the test plan for this revision. (Show Details)Jun 2 2022, 10:15 PM
Harbormaster completed remote builds in B9611: Diff 13322.Jun 2 2022, 10:22 PM
atul requested review of this revision.Jun 2 2022, 10:22 PM
atul added a child revision: D4207: [web] Introduce minimally viable `Alert` component.Jun 2 2022, 11:18 PM
tomek accepted this revision.Jun 3 2022, 4:38 AM
tomek added inline comments.
web/modals/chat/invalid-upload.react.js
11–17 ↗(On Diff #13322)
This revision is now accepted and ready to land.Jun 3 2022, 4:38 AM
atul updated this revision to Diff 13333.Jun 4 2022, 4:45 PM

cherrypick before landing

Harbormaster completed remote builds in B9620: Diff 13333.Jun 4 2022, 4:50 PM
atul updated this revision to Diff 13334.Jun 4 2022, 5:06 PM

address feedback

Harbormaster completed remote builds in B9621: Diff 13334.Jun 4 2022, 5:11 PM
Closed by commit rCOMM9801af9b88c2: [web] Turn `InvalidUploadModal` into a functional component (authored by atul). · Explain WhyJun 4 2022, 6:01 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM9801af9b88c2: [web] Turn `InvalidUploadModal` into a functional component.

Revision Contents
Changeset List

PathSize
web/
modals/
chat/
44 lines

Diff 13333

View Options

web/modals/chat/invalid-upload.react.js

Loading...