Paths

Table of Contentst

Differential D4224

[DRAFT] [services] Tests - Backup Utils - Add BackupData struct
AbandonedPublic
Actions

Authored by • karol on Jun 7 2022, 6:48 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Dec 15, 8:28 AM

	Unknown Object (File)
	Sun, Dec 15, 8:27 AM

	Unknown Object (File)
	Sun, Dec 15, 8:19 AM

	Unknown Object (File)
	Sun, Dec 1, 11:43 PM

	Unknown Object (File)
	Thu, Nov 28, 4:52 AM

	Unknown Object (File)
	Nov 17 2024, 4:34 PM

	Unknown Object (File)
	Nov 17 2024, 1:31 PM

	Unknown Object (File)
	Oct 26 2024, 2:58 AM

View All 64 Files

Subscribers

Details

Reviewers

tomek
• max
varun

Summary

Depends on D4164

I decided to wrap backup information in the struct. It contains user/backup/device ids and backup/logs sizes.

Test Plan

this doesn't do anything on its own. Tests can be built.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Jun 7 2022, 6:48 AM

Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJun 7 2022, 6:48 AM

Harbormaster completed remote builds in B9653: Diff 13379.Jun 7 2022, 7:19 AM

• karol requested review of this revision.Jun 7 2022, 7:19 AM

• karol edited the summary of this revision. (Show Details)Jun 7 2022, 7:38 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, • max, varun.

• karol added a parent revision: D4164: [services] Tests - Add backup utils.

• karol added a child revision: D4225: [services] Tests - Add tools.

• karol retitled this revision from [services] Tests - Backup Utils - Add BackupData struct to [DRAFT] [services] Tests - Backup Utils - Add BackupData struct.Jun 8 2022, 12:54 AM

tomek requested changes to this revision.Jun 8 2022, 2:05 AM

tomek added inline comments.

services/commtest/src/backup_utils.rs
11–12	Maybe we should create a separate type for a chunk, so that it is ensured that for every chunk there's a log vector? Currently it is possible for `backup_chunk_sizes` and `logs_sizes` to have different sizes.

This revision now requires changes to proceed.Jun 8 2022, 2:05 AM

• karol added inline comments.Jun 10 2022, 5:57 AM

services/commtest/src/backup_utils.rs
11–12	The new version of tests will have this (if I understand you correctly).

• karol abandoned this revision.Jun 13 2022, 4:50 AM

• karol removed a child revision: D4225: [services] Tests - Add tools.

• karol removed a parent revision: D4164: [services] Tests - Add backup utils.

Revision Contents
Changeset List

Path

Size

services/

commtest/

src/

backup_utils.rs

8 lines

Diff 13379

services/commtest/src/backup_utils.rs

Loading...