Page MenuHomePhabricator
Differential D4241

[yarn] Restore `fortawesome`-related dependencies to fix icon issue
ClosedPublic
Actions

Authored by atul on Jun 8 2022, 7:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 18, 7:25 PM
Unknown Object (File)
Thu, Mar 6, 10:50 PM
Unknown Object (File)
Thu, Mar 6, 8:11 PM
Unknown Object (File)
Thu, Mar 6, 3:00 AM
Unknown Object (File)
Tue, Mar 4, 7:45 PM
Unknown Object (File)
Feb 17 2025, 1:14 PM
Unknown Object (File)
Jan 30 2025, 5:35 PM
Unknown Object (File)
Jan 30 2025, 5:35 PM
View All Files
Subscribers
• abosh
• adrian

Details

Reviewers
tomek
• jacek
ashoat
Commits
rCOMM7e9032d9732d: [yarn] Restore `fortawesome`-related dependencies to fix icon issue
Summary

We were experiencing strange behavior with fortawesome icons. They were either not appearing correctly (way too large) or not appearing at all.

Linear context:
https://linear.app/comm/issue/ENG-1228/filters-icon-way-too-large-on-web-calendar

I think the fortawesome/react-fontawesome dependency needs to be bumped in lockstep with its peer dependencies in order to keep things working.

With this change I just rolled back and fixed version numbers so we're at a state where things look as expected on both dev and prod.

I'll separately look at bumping these dependencies while preserving the appearance. (Might be a place to try snapshot testing to prevent this sort of regression in the future?)

Test Plan

Tested on dev and prod and things looked as they used to:

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
landing/
10 lines
web/
8 lines
51 lines

Diff 13452

View Options

landing/package.json

Show First 20 Lines • Show All 191 Lines • ▼ Show 20 Lines if (messagesFromDatabase.size() > 0) {
// if there are undelivered messages in the database. If so, we are // if there are undelivered messages in the database. If so, we are
// erasing the messages to deliver from rabbitMQ which are handled by // erasing the messages to deliver from rabbitMQ which are handled by
// DeliveryBroker. // DeliveryBroker.
DeliveryBroker::getInstance().erase(clientDeviceID); DeliveryBroker::getInstance().erase(clientDeviceID);
} }
tunnelbroker::GetResponse response; tunnelbroker::GetResponse response;
auto respondToWriter = auto respondToWriter =
[&writer, &response](std::string fromDeviceID, std::string payload) { [&writer, &response](std::string fromDeviceID, std::string payload) {
response.set_fromdeviceid(fromDeviceID); response.mutable_responsemessage()->set_fromdeviceid(fromDeviceID);
response.set_payload(payload); response.mutable_responsemessage()->set_payload(payload);
if (!writer->Write(response)) { if (!writer->Write(response)) {
throw std::runtime_error( throw std::runtime_error(
"gRPC: 'Get' writer error on sending data to the client"); "gRPC: 'Get' writer error on sending data to the client");
} }
response.Clear(); response.Clear();
}; };
for (auto &messageFromDatabase : messagesFromDatabase) { for (auto &messageFromDatabase : messagesFromDatabase) {
respondToWriter( respondToWriter(
Show All 28 Lines
View Options

web/package.json

Show First 20 Lines • Show All 191 Lines • ▼ Show 20 Lines if (messagesFromDatabase.size() > 0) {
// if there are undelivered messages in the database. If so, we are // if there are undelivered messages in the database. If so, we are
// erasing the messages to deliver from rabbitMQ which are handled by // erasing the messages to deliver from rabbitMQ which are handled by
// DeliveryBroker. // DeliveryBroker.
DeliveryBroker::getInstance().erase(clientDeviceID); DeliveryBroker::getInstance().erase(clientDeviceID);
} }
tunnelbroker::GetResponse response; tunnelbroker::GetResponse response;
auto respondToWriter = auto respondToWriter =
[&writer, &response](std::string fromDeviceID, std::string payload) { [&writer, &response](std::string fromDeviceID, std::string payload) {
response.set_fromdeviceid(fromDeviceID); response.mutable_responsemessage()->set_fromdeviceid(fromDeviceID);
response.set_payload(payload); response.mutable_responsemessage()->set_payload(payload);
if (!writer->Write(response)) { if (!writer->Write(response)) {
throw std::runtime_error( throw std::runtime_error(
"gRPC: 'Get' writer error on sending data to the client"); "gRPC: 'Get' writer error on sending data to the client");
} }
response.Clear(); response.Clear();
}; };
for (auto &messageFromDatabase : messagesFromDatabase) { for (auto &messageFromDatabase : messagesFromDatabase) {
respondToWriter( respondToWriter(
Show All 28 Lines
View Options

yarn.lock

Show First 20 Lines • Show All 191 Lines • ▼ Show 20 Lines if (messagesFromDatabase.size() > 0) {
// if there are undelivered messages in the database. If so, we are // if there are undelivered messages in the database. If so, we are
// erasing the messages to deliver from rabbitMQ which are handled by // erasing the messages to deliver from rabbitMQ which are handled by
// DeliveryBroker. // DeliveryBroker.
DeliveryBroker::getInstance().erase(clientDeviceID); DeliveryBroker::getInstance().erase(clientDeviceID);
} }
tunnelbroker::GetResponse response; tunnelbroker::GetResponse response;
auto respondToWriter = auto respondToWriter =
[&writer, &response](std::string fromDeviceID, std::string payload) { [&writer, &response](std::string fromDeviceID, std::string payload) {
response.set_fromdeviceid(fromDeviceID); response.mutable_responsemessage()->set_fromdeviceid(fromDeviceID);
response.set_payload(payload); response.mutable_responsemessage()->set_payload(payload);
if (!writer->Write(response)) { if (!writer->Write(response)) {
throw std::runtime_error( throw std::runtime_error(
"gRPC: 'Get' writer error on sending data to the client"); "gRPC: 'Get' writer error on sending data to the client");
} }
response.Clear(); response.Clear();
}; };
for (auto &messageFromDatabase : messagesFromDatabase) { for (auto &messageFromDatabase : messagesFromDatabase) {
respondToWriter( respondToWriter(
Show All 28 Lines