Page MenuHomePhabricator

[yarn] Restore `fortawesome`-related dependencies to fix icon issue
ClosedPublic

Authored by atul on Jun 8 2022, 7:02 AM.
Tags
None
Referenced Files
F3536302: D4241.diff
Wed, Dec 25, 6:13 PM
Unknown Object (File)
Mon, Dec 9, 1:32 PM
Unknown Object (File)
Tue, Nov 26, 8:06 PM
Unknown Object (File)
Nov 11 2024, 2:54 PM
Unknown Object (File)
Nov 9 2024, 11:41 AM
Unknown Object (File)
Nov 9 2024, 11:41 AM
Unknown Object (File)
Nov 8 2024, 8:08 AM
Unknown Object (File)
Nov 5 2024, 2:01 AM

Details

Summary

We were experiencing strange behavior with fortawesome icons. They were either not appearing correctly (way too large) or not appearing at all.

Linear context:
https://linear.app/comm/issue/ENG-1228/filters-icon-way-too-large-on-web-calendar

I think the fortawesome/react-fontawesome dependency needs to be bumped in lockstep with its peer dependencies in order to keep things working.

With this change I just rolled back and fixed version numbers so we're at a state where things look as expected on both dev and prod.

I'll separately look at bumping these dependencies while preserving the appearance. (Might be a place to try snapshot testing to prevent this sort of regression in the future?)

Test Plan

Tested on dev and prod and things looked as they used to:

Diff Detail

Repository
rCOMM Comm
Branch
fix-icons (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage