Minor change — changed all occurrences of "M1" (not in code, in comments and documentation) to "ARM-based Mac(s)". This is because now that M2 exists, M1 only classifies the the first generation of Apple silicon Macs.
Details
Details
N/A, these were all comments and documentation so these changes are all only cosmetic.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| keyserver/docker-compose.yml | ||
|---|---|---|
| 31 ↗ | (On Diff #13448) | Just a minor note — this is the only usage of x64 in the codebase. However, there is no consistent usage of x86 anywhere else (x86-64, x86_64, and Intel x86-64) are all used in the codebase. Should we should replace this with anything like x86-64 or decide on a standard? I think it's completely fine as it is but just wanted to let you know @ashoat, since you wrote this. |
Comment Actions
Please make sure that all lines here are no more than 80 chars long. This is generally a hard rule in the codebase, with a few rare exceptions (eg. Objective-C code)
| flake.nix | ||
|---|---|---|
| 18 ↗ | (On Diff #13448) | Let's use the counterpart to x86_64-linux here please (probably something like aarch64 or something, please check Nix packages website) |
| keyserver/bash/source-nvm.sh | ||
| 8 ↗ | (On Diff #13448) | All lines in the codebase should be no more than 80 chars long |
| 8 ↗ | (On Diff #13448) | All lines in the codebase should be no more than 80 chars long |
| keyserver/docker-compose.yml | ||
| 32 ↗ | (On Diff #13448) | All lines in the codebase should be no more than 80 chars long |
| native/ios/Podfile | ||
| 67–68 ↗ | (On Diff #13448) | I think @marcinwasowicz accidentally made these lines more than 80 chars long, can you fix? |
Comment Actions
Address inline feedback. In addition to the lines @ashoat pointed out as being >80 characters, I noticed the rest of the file also had numerous lines that were >80 characters, so I fixed that too. Making all files have lines <= 80 characters long for the rest of the codebase is probably better suited to another diff since I'm assuming there are more files like this. Additionally, for the future, I suggest using a linter or something for shell scripts and configuration files (can be really simple, just to make sure overall style (like 80 character limit) is met).
| flake.nix | ||
|---|---|---|
| 18 ↗ | (On Diff #13448) | Sure! The counterpart for Apple silicon Macs is indeed aarch64: From the NixOS wiki. |
Comment Actions
Reverting prior commit's code changes, only addressing inline feedback from @ashoat (about 80 characters in comments/documentation) because the builds failed with the code changes. The log files indicated issues with pod, which is probably associated with my changes to the Podfile's code. This commit only modifies comments/documentation.