Page MenuHomePhabricator

[docs] Update Phabricator instructions in dev_environment.md
ClosedPublic

Authored by ashoat on Jun 13 2022, 2:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 2, 2:49 PM
Unknown Object (File)
Oct 7 2024, 11:15 PM
Unknown Object (File)
Oct 7 2024, 11:15 PM
Unknown Object (File)
Oct 7 2024, 11:15 PM
Unknown Object (File)
Oct 7 2024, 11:14 PM
Unknown Object (File)
Oct 7 2024, 11:12 PM
Unknown Object (File)
Oct 6 2024, 12:18 PM
Unknown Object (File)
Oct 6 2024, 11:03 AM

Details

Summary

These instructions are really confusing. They go too deep on things you really should not be doing, and don't explain things that you really need to understand.

This diff attempts to simplify the instructions by removing the unneeded parts, and also adds some things that everybody needs to know.

Linear task: ENG-427

Test Plan

I read through my edits carefully and made sure I don't have any stray single- or double-quote characters

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat published this revision for review.Jun 13 2022, 11:22 PM

Hmmm not sure what's going on with CI, but this is a docs diff so I'm sure it doesn't matter

varun requested changes to this revision.Jun 14 2022, 6:48 AM
varun added inline comments.
docs/dev_environment.md
816 ↗(On Diff #13477)

I think you can omit the Differential Revision: stuff here since it's explained in the next section anyway

830 ↗(On Diff #13477)

Is this official terminology or should we put it in quotes?

This revision now requires changes to proceed.Jun 14 2022, 6:48 AM
This revision is now accepted and ready to land.Jun 14 2022, 10:27 AM
This revision was landed with ongoing or failed builds.Jun 14 2022, 10:29 AM
This revision was automatically updated to reflect the committed changes.