[web] Swap "Current password" with "New password" in `PasswordChangeModal`
ClosedPublic
Actions

Authored by • abosh on Jun 15 2022, 1:37 PM.

Details

Reviewers

atul
tomek

Commits

rCOMMa62e14d32466: [web] Swap "Current password" with "New password" in `PasswordChangeModal`

Summary

Linear issue with more context here.

Swap "Current password" Input with "New password" Input in PasswordChangeModal to match native along with numerous other apps.

Before:

After:

Test Plan

Looks as expected on Chrome/Safari, and changed my password twice and logged back in, everything worked fine.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• abosh created this revision.Jun 15 2022, 1:37 PM

Herald added subscribers: • adrian, ashoat. · View Herald TranscriptJun 15 2022, 1:37 PM

• abosh edited the summary of this revision. (Show Details)Jun 15 2022, 1:38 PM

• abosh edited the test plan for this revision. (Show Details)

Removed extra line

Harbormaster completed remote builds in B9777: Diff 13533.Jun 15 2022, 1:42 PM

Harbormaster completed remote builds in B9778: Diff 13534.Jun 15 2022, 1:47 PM

• abosh requested review of this revision.Jun 15 2022, 1:47 PM

atul accepted this revision.Jun 17 2022, 11:10 AM

This revision is now accepted and ready to land.Jun 17 2022, 11:10 AM

Closed by commit rCOMMa62e14d32466: [web] Swap "Current password" with "New password" in `PasswordChangeModal` (authored by • abosh). · Explain WhyJun 17 2022, 1:46 PM

This revision was automatically updated to reflect the committed changes.

• abosh added a commit: rCOMMa62e14d32466: [web] Swap "Current password" with "New password" in `PasswordChangeModal`.

Revision Contents
Changeset List

Path

Size

web/

settings/

password-change-modal.js

22 lines

Diff 13554

View Options

web/settings/password-change-modal.js

[web] Swap "Current password" with "New password" in `PasswordChangeModal`ClosedPublicActions