[keyserver] Add maxDirSizeMiB to BackupConfig
ClosedPublic
Actions

Authored by ashoat on Jun 15 2022, 5:41 PM.

Details

Reviewers

atul
• abosh

Commits

rCOMM77c90e8592f4: [keyserver] Add maxDirSizeMiB to BackupConfig

Summary

This config allows a user to specify a maximum space usage of the backup directory. This should resolve ENG-1234.

We will always keep at least one backup, ignoring maxDirSizeMiB if the single most recent backup exceeds it. Otherwise we will delete old backups until the usage falls below the max.

Depends on D4282

Test Plan

I tested setting maxDirSizeMiB to fit 2.5 backups, then changed cron.js so it ran a backup soon. I confirmed after running that there were two backups, that they were the two most recent, and that one of them was new.
Then I tested setting it to some low number, smaller than one backup. Made sure after running that there was precisely one brand new backup.

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/backups

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Jun 15 2022, 5:41 PM

Herald added subscribers: • adrian, tomek. · View Herald TranscriptJun 15 2022, 5:41 PM

Harbormaster completed remote builds in B9780: Diff 13537.Jun 15 2022, 5:50 PM

ashoat requested review of this revision.Jun 15 2022, 5:50 PM

Adding a minor comment about style, not sure about the rest of this revision because of lack of experience with this side of the codebase, so deferring to @atul on that. I'll investigate the backups aspect of the codebase further once he reviews it.

keyserver/src/cron/backups.js
261 ↗	(On Diff #13537)	Referencing same style fix from D4282. It's clearer to name this `sortedBackupInfos` so that `mostRecentBackup`, and the backwards iteration through `backupInfos` makes sense.