[lib] [web] Use `slice(0, -1)` instead of `slice(0, ...length - 1)`
ClosedPublic
Actions

Authored by • abosh on Jun 21 2022, 11:49 AM.

Details

Reviewers

atul
tomek

Commits

rCOMM26d131fd1804: [lib] [web] Use `slice(0, -1)` instead of `slice(0, ...length - 1)`

Summary

Noticed some instances of slice() being called with the length property of the array that was being sliced instead of the more concise syntax using negative indices.

Test Plan

N/A, but checked to make sure slice() functions the same with the negative index and when called with its positive counterpart (...length - 1, for example).

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• abosh created this revision.Jun 21 2022, 11:49 AM

Herald added subscribers: • adrian, ashoat. · View Herald TranscriptJun 21 2022, 11:49 AM

• abosh edited the test plan for this revision. (Show Details)Jun 21 2022, 11:49 AM

Harbormaster completed remote builds in B9857: Diff 13635.Jun 21 2022, 11:54 AM

• abosh requested review of this revision.Jun 21 2022, 11:54 AM

This makes sense to me, I tend to use negative indices liberally when I'm writing python or whatever.

Kind of a style thing so tagging @ashoat to see if he cares/has any thoughts

This revision is now accepted and ready to land.Jun 21 2022, 12:06 PM

Makes sense. Also wanted to note that slice(0, -1) is what's used in the rest of the codebase, i.e., this change updates the only usages of slice() that don't already use the negative index syntax.

In D4316#121640, @yayabosh wrote:

Makes sense. Also wanted to note that slice(0, -1) is what's used in the rest of the codebase, i.e., this change updates the only usages of slice() that don't already use the negative index syntax.

Okay cool, then it's probably good to land

Closed by commit rCOMM26d131fd1804: [lib] [web] Use `slice(0, -1)` instead of `slice(0, ...length - 1)` (authored by • abosh). · Explain WhyJun 21 2022, 12:14 PM

This revision was automatically updated to reflect the committed changes.

• abosh added a commit: rCOMM26d131fd1804: [lib] [web] Use `slice(0, -1)` instead of `slice(0, ...length - 1)`.

This makes sense to me