Page MenuHomePhabricator
Differential D4366

[ignore] Try relative path instead of absolute for `native/.flowconfig`
AbandonedPublic
Actions

Authored by atul on Jun 27 2022, 11:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 21, 7:11 PM
Unknown Object (File)
Fri, Jun 21, 7:11 PM
Unknown Object (File)
Fri, Jun 21, 7:11 PM
Unknown Object (File)
Fri, Jun 21, 7:10 PM
Unknown Object (File)
Fri, Jun 21, 6:52 PM
Unknown Object (File)
Jun 4 2024, 10:46 AM
Unknown Object (File)
Apr 10 2024, 8:44 PM
Unknown Object (File)
Apr 8 2024, 3:08 AM
View All 89 Files
Subscribers
• adrian
ashoat

Details

Reviewers
tomek
• jacek
• abosh
Summary

Right now the .flowconfig for the native module expects the root directory to be named comm. This is has been an issue with Buildkite in the past because it names the root directory after the name of the "pipeline."

We previously got around this by naming the flow "pipeline" to "comm".

However, now that we're using the Buildkite docker plugin, it names the root directory "workdir" which causes problems with flow.

This diff is to test whether changing the path from absolute to relative fixes things.

(It's in the draft state because I'm just experimenting and haven't fully read up on the glob rules to ensure that the before/after are fully equivalent).

Test Plan

CI

Diff Detail

Repository
rCOMM Comm
Branch
june27 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jun 27 2022, 11:06 AM
Herald added subscribers: • adrian, ashoat. · View Herald TranscriptJun 27 2022, 11:06 AM
Harbormaster completed remote builds in B10013: Diff 13849.Jun 27 2022, 11:11 AM
atul requested review of this revision.Jun 27 2022, 11:11 AM
atul updated this revision to Diff 13850.Jun 27 2022, 11:17 AM

try again

Harbormaster completed remote builds in B10014: Diff 13850.Jun 27 2022, 11:23 AM
atul updated this revision to Diff 13851.Jun 27 2022, 11:28 AM

try <PROJECT_ROOT>

Harbormaster completed remote builds in B10015: Diff 13851.Jun 27 2022, 11:33 AM
• abosh edited the summary of this revision. (Show Details)Jun 27 2022, 11:48 AM
atul abandoned this revision.Jun 27 2022, 11:50 AM

resolved

ashoat added a comment.Jun 28 2022, 1:09 PM

resolved

How did this get resolved? I assume we're still expecting that the folder is named comm, yeah?

atul added a comment.EditedJun 28 2022, 4:50 PM
In D4366#123942, @ashoat wrote:

resolved

How did this get resolved? I assume we're still expecting that the folder is named comm, yeah?

It is still an issue that flow has errors if the root directory is named anything other than comm. What was "resolved" (which I should have clarified), was that I was able to rename workdir to comm with the Buildkite Docker plugin to appease flow.

ashoat added a comment.Jun 29 2022, 10:55 AM

Understood, thanks. Not sure why <PROJECT_ROOT> doesn't work, ugh

atul added a comment.Jun 29 2022, 10:58 AM

Not sure why <PROJECT_ROOT> doesn't work, ugh

"The location of the .flowconfig is significant. Flow treats the directory that contains the .flowconfig as the project root. By default Flow includes all the source code under the project root. The paths in the [include] section are relative to the project root. Some other configuration also lets you reference the project root via the macro <PROJECT_ROOT>." (https://flow.org/en/docs/config/#toc-where-to-put-the-flowconfig)

ashoat added a comment.Jun 29 2022, 1:13 PM

Ah okay, fair

Revision Contents
Changeset List

PathSize
native/
4 lines

Diff 13851

View Options

native/.flowconfig

Loading...