package.json`
ClosedPublic
Actions

Authored by atul on Jun 27 2022, 5:20 PM.

Details

Reviewers

• jacek
tomek
• abosh
• karol

Commits

rCOMM3ceabb267af8: [services] Remove `build-[blob/backup]-base` from `services/package.json`

Summary

We no longer have a base image for blob/backup base. These commands are no longer relevant.

Test Plan

NA, searched codebase

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Jun 27 2022, 5:20 PM

Herald added subscribers: • karol, • adrian, ashoat. · View Herald TranscriptJun 27 2022, 5:20 PM

Harbormaster completed remote builds in B10026: Diff 13865.Jun 27 2022, 5:29 PM

atul requested review of this revision.Jun 27 2022, 5:29 PM

tomek accepted this revision.Jun 28 2022, 4:39 AM

tomek added a reviewer: • karol.

I think there should be a newline at the end of this file. Every other package.json in the codebase ends with a newline, and it is the POSIX standard for lines.

In D4371#123746, @yayabosh wrote:

I think there should be a newline at the end of this file. Every other package.json in the codebase ends with a newline, and it is the POSIX standard for lines.

I think this diff adds a newline?

Ah that's totally my bad. I saw the No newline at end of file here and thought it wasn't on the new version of the diff. This looks good!

In D4371#123869, @yayabosh wrote:

Ah that's totally my bad. I saw the No newline at end of file here and thought it wasn't on the new version of the diff. This looks good!

No worries, I actually just viewed it on mobile (where the diff is one column) and it totally looks like the newline is missing the way Phabricator formats it.

• karol accepted this revision.Jun 29 2022, 6:15 AM

This revision is now accepted and ready to land.Jun 29 2022, 6:15 AM

rebase after cherrypicking and before landing

Harbormaster completed remote builds in B10107: Diff 13971.Jun 29 2022, 10:00 AM

Closed by commit rCOMM3ceabb267af8: [services] Remove `build-[blob/backup]-base` from `services/package.json` (authored by atul). · Explain WhyJun 29 2022, 10:59 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM3ceabb267af8: [services] Remove `build-[blob/backup]-base` from `services/package.json`.