Page MenuHomePhabricator
Differential D4374

[ignore] Experimenting with Android build
AbandonedPublic
Actions

Authored by atul on Jun 27 2022, 7:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jun 26, 2:01 PM
Unknown Object (File)
Fri, Jun 21, 7:11 PM
Unknown Object (File)
Fri, Jun 21, 7:11 PM
Unknown Object (File)
Fri, Jun 21, 7:11 PM
Unknown Object (File)
Fri, Jun 21, 7:11 PM
Unknown Object (File)
Fri, Jun 21, 7:11 PM
Unknown Object (File)
Fri, Jun 21, 7:11 PM
Unknown Object (File)
Fri, Jun 21, 7:11 PM
View All Files
Subscribers
• adrian
ashoat
• jacek
tomek

Details

Reviewers
• abosh
Summary

Just messing with the Android build to try to speed it up.

Test Plan

NA

Diff Detail

Repository
rCOMM Comm
Branch
june27 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jun 27 2022, 7:46 PM
Herald added subscribers: • adrian, tomek, ashoat. · View Herald TranscriptJun 27 2022, 7:46 PM
Harbormaster completed remote builds in B10030: Diff 13869.Jun 27 2022, 7:55 PM
atul requested review of this revision.Jun 27 2022, 7:55 PM
atul updated this revision to Diff 13870.Jun 27 2022, 8:14 PM

very naive concurrency

atul updated this revision to Diff 13871.Jun 27 2022, 8:15 PM

trial 2

atul updated this revision to Diff 13872.Jun 27 2022, 8:16 PM

trial 3

Harbormaster completed remote builds in B10031: Diff 13870.Jun 27 2022, 8:22 PM
Harbormaster completed remote builds in B10032: Diff 13871.
Harbormaster completed remote builds in B10033: Diff 13872.Jun 27 2022, 8:25 PM
atul updated this revision to Diff 13873.Jun 27 2022, 8:33 PM

one more trial

Harbormaster completed remote builds in B10034: Diff 13873.Jun 27 2022, 8:40 PM
atul updated this revision to Diff 13874.Jun 27 2022, 9:17 PM

double threads

Harbormaster completed remote builds in B10035: Diff 13874.Jun 27 2022, 9:26 PM
atul updated this revision to Diff 13875.Jun 27 2022, 10:10 PM

trigger

Harbormaster completed remote builds in B10036: Diff 13875.Jun 27 2022, 10:19 PM
atul updated this revision to Diff 13876.Jun 27 2022, 11:56 PM

ignore

atul updated this revision to Diff 13877.Jun 28 2022, 12:05 AM

seems faster locally

Harbormaster completed remote builds in B10037: Diff 13876.Jun 28 2022, 12:05 AM
Harbormaster completed remote builds in B10038: Diff 13877.Jun 28 2022, 12:14 AM
• abosh added a comment.Jun 28 2022, 6:39 AM

Dang, I thought I could do more code review but I'm the placeholder guy they put on diffs to ignore! 😂😂 carry on 😑

atul updated this revision to Diff 13903.Jun 28 2022, 7:38 AM

trigger

Harbormaster completed remote builds in B10054: Diff 13903.Jun 28 2022, 7:47 AM
atul added a subscriber: • jacek.Jun 28 2022, 5:41 PM
In D4374#123696, @yayabosh wrote:

Dang, I thought I could do more code review but I'm the placeholder guy they put on diffs to ignore! 😂😂 carry on 😑

LOL sorry it insisted on adding a reviewer and I figured it would be a bit less disruptive since you're in a closer timezone than @palys-swm or @def-au1t

ashoat added a comment.Jun 29 2022, 10:57 AM

Let's make sure we have a task for this work, and let's make sure we talk through prioritization before you bump a brand new task to the front of your queue! Open to this but just want to make sure I'm looped into discussions about prioritization, especially in the context of all the high-pri stuff you have on your plate right now

atul abandoned this revision.Jun 29 2022, 10:58 AM

Revision Contents
Changeset List

PathSize
native/
android/
app/
9 lines
buildSrc/
src/
main/
groovy/
app/
comm/
gradle/
tasks/
32 lines

Diff 13903

View Options

native/android/app/build.gradle

Loading...
View Options

native/android/buildSrc/src/main/groovy/app/comm/gradle/tasks/GitModules.groovy

Loading...