Page MenuHomePhabricator

[services] redact server keypair in config struct
ClosedPublic

Authored by varun on Jun 28 2022, 12:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 1, 2:28 AM
Unknown Object (File)
Aug 17 2024, 2:11 AM
Unknown Object (File)
Aug 8 2024, 3:21 PM
Unknown Object (File)
Aug 8 2024, 3:21 PM
Unknown Object (File)
Aug 8 2024, 3:21 PM
Unknown Object (File)
Aug 8 2024, 3:18 PM
Unknown Object (File)
Jul 31 2024, 12:33 AM
Unknown Object (File)
Jul 21 2024, 6:26 PM

Details

Summary

We should not reveal the keypair in our logs. I've manually implemented the Debug trait to redact the server_keypair field.

Resolves https://linear.app/comm/issue/ENG-1298/redact-sensitive-fields-in-types-that-implement-debug-trait

Test Plan

Printed the Config struct and confirmed the keypair field was redacted

Config { server_keypair: "redacted" }

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable