Following D4151, the keyserver migration code should automatically setup the database when it sees the meta table is missing. As a result, it's no longer necessary for the user to manually call create-db.js.
Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
(removed myself as reviewer bc docs diff, feel free to add back if there's something specific I might have context on)
| docs/dev_environment.md | ||
|---|---|---|
| 546 ↗ | (On Diff #13972) | Couple changes I noticed that could be made here.
I modified this to "we'll use Babel" since it seemed less wordy and more concise while carrying the same meaning. The "first" is implied by the ordering of the sentences and the commands below it (yarn babel-build before everything else).
Changed "We" to "We'll" since the tense of the rest of the paragraph is future tense. Some examples:
|
| 546 ↗ | (On Diff #13972) | I like this change from "Now let's run a script to ..." |
Comment Actions
Accepting, because the scope of this diff is to remove references to create-db.js. But in the process of reviewing, saw some minor minor wording changes that could be made. Up to you and rest of reviewers.
| docs/dev_environment.md | ||
|---|---|---|
| 546 ↗ | (On Diff #13972) | Thanks, I mostly took your advice but kept "need to"... I think the "Before we can X we need to Y" construction makes more sense than "Before we can X we'll Y" since it clarifies that step Y is necessary for step X to work (I also fixed up your single-quote to an apostrophe) |