Differential D4416
[web] Leave `ThreadSettingsGeneralTab` open after settings are saved Authored by • abosh on Jun 30 2022, 11:30 AM. Tags None Referenced Files
Details Relevant Linear issue here. Leaves ThreadSettingsGeneralTab open after hitting the "Save" button. This ensures that the user can make any more changes if they'd like to even after clicking "Save" without having to reopen the modal manually. Will add a nicer transition to the Save button in a subsequent diff. See Linear issue for that here. Looks and works as expected on Chrome/Safari:
Diff Detail
Event TimelineComment Actions This design works ok, but have an important downside: it's not clear which changes were already committed and which will be after clicking save button. The previous design was also affected, but after each save a user had to open the modal again and see the current server state. It might be even more confusing when there was an error.
Comment Actions
This is a great observation. I think your suggestion:
is a good one. However, at least for now, the ThreadSettingsGeneralTab automatically updates once a change is made. By that I mean if the user decides to update the thread name, thread description, or thread color those are all changes they make and see inside the modal. So disabling the Save button should be enough to convince the user their changes were committed. That way, if they make another change the button will become enabled, and they will know that they have uncommitted changes. I can handle that (disabling the save button when there are no pending changes) in a subsequent diff, although I think it is very connected to this diff. Comment Actions
This sounds like a good compromise solution that should be easy to implement. @yayabosh, can you create a Linear task for this follow-up? | ||||||||||||||||||||||||||||||||||