Page MenuHomePhabricator
Differential D4932

[web] Simplify `return` value of `changeThreadSettingsAction`
ClosedPublic
Actions

Authored by • abosh on Aug 23 2022, 2:34 PM.
Tags
None
Referenced Files
F5894451: D4932.diff
Thu, Apr 17, 10:24 AM
Unknown Object (File)
Tue, Apr 8, 10:39 PM
Unknown Object (File)
Tue, Apr 8, 10:38 PM
Unknown Object (File)
Tue, Apr 8, 10:38 PM
Unknown Object (File)
Tue, Apr 8, 10:38 PM
Unknown Object (File)
Mon, Mar 31, 5:22 PM
Unknown Object (File)
Tue, Mar 18, 6:55 PM
Unknown Object (File)
Mar 13 2025, 7:08 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
tomek
atul
Commits
rCOMM669f84ba59ec: [web] Simplify `return` value of `changeThreadSettingsAction`
Summary

Noticed this when reading through @tomek's feedback on D4416 when requesting review on D4931. Looks like I forgot to add this in after he accepted!

Test Plan

Flow, @tomek's feedback

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
web/
modals/
threads/
settings/
3 lines

Diff 16012

View Options

web/modals/threads/settings/thread-settings-general-tab.react.js

FROM rust:1.67 as builder FROM rust:1.67 as builder
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \ RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
build-essential cmake git libgtest-dev libssl-dev zlib1g-dev \ build-essential cmake git libgtest-dev libssl-dev zlib1g-dev \
&& rm -rf /var/lib/apt/lists/* \ && rm -rf /var/lib/apt/lists/* \
&& mkdir -p /home/root/app/ && mkdir -p /home/root/app/
WORKDIR /home/root/app WORKDIR /home/root/app
# Install more recent version of protobuf, must be ran as root # Install more recent version of protobuf, must be ran as root
COPY scripts/install_protobuf.sh ../../scripts/install_protobuf.sh COPY scripts/install_protobuf.sh ../../scripts/install_protobuf.sh
RUN ../../scripts/install_protobuf.sh RUN ../../scripts/install_protobuf.sh
RUN mkdir -p /home/comm/app/identity RUN mkdir -p /home/comm/app/identity
WORKDIR /home/comm/app/identity WORKDIR /home/comm/app/identity
RUN cargo init --bin
COPY services/identity/Cargo.toml services/identity/Cargo.lock ./
COPY shared/ ../../shared/
# Cache build dependencies in a new layer
RUN cargo build --release
RUN rm src/*.rs
COPY services/identity . COPY services/identity .
COPY shared/protos/identity_client.proto ../../shared/protos/
COPY shared/comm-opaque2 ../../shared/comm-opaque2
RUN cargo install --locked --path . RUN cargo install --locked --path .
FROM debian:bullseye-slim FROM debian:bullseye-slim
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \ RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
ca-certificates \ ca-certificates \
&& rm -rf /var/lib/apt/lists/* \ && rm -rf /var/lib/apt/lists/* \
Show All 10 Lines