Page MenuHomePhabricator
Differential D4932

[web] Simplify `return` value of `changeThreadSettingsAction`
ClosedPublic
Actions

Authored by • abosh on Aug 23 2022, 2:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 18, 6:55 PM
Unknown Object (File)
Thu, Mar 13, 7:08 PM
Unknown Object (File)
Thu, Mar 6, 6:29 PM
Unknown Object (File)
Wed, Mar 5, 8:14 AM
Unknown Object (File)
Wed, Mar 5, 12:41 AM
Unknown Object (File)
Feb 17 2025, 3:55 AM
Unknown Object (File)
Feb 17 2025, 3:55 AM
Unknown Object (File)
Feb 17 2025, 3:54 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
tomek
atul
Commits
rCOMM669f84ba59ec: [web] Simplify `return` value of `changeThreadSettingsAction`
Summary

Noticed this when reading through @tomek's feedback on D4416 when requesting review on D4931. Looks like I forgot to add this in after he accepted!

Test Plan

Flow, @tomek's feedback

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
web/
modals/
threads/
settings/
3 lines

Diff 16012

View Options

web/modals/threads/settings/thread-settings-general-tab.react.js

Show All 31 Lines.questionText {
color: var(--white-100); color: var(--white-100);
} }
.icon { .icon {
margin-left: 24px; margin-left: 24px;
} }
.answerContainer { .answerContainer {
max-height: 0; display: grid;
overflow: hidden; grid-template-rows: 0fr;
transition: grid-template-rows 500ms;
} }
.activeAnswerContainer { .activeAnswerContainer {
max-height: fit-content; grid-template-rows: 1fr;
} }
.answerText { .answerText {
color: var(--white-100); color: var(--white-100);
margin-top: 16px; margin-top: 16px;
overflow: hidden;
} }
.link { .link {
color: inherit; color: inherit;
text-decoration: underline; text-decoration: underline;
transition: color 150ms; transition: color 150ms;
} }
.link:hover { .link:hover {
color: var(--violet-dark-100); color: var(--violet-dark-100);
transition: color 150ms; transition: color 150ms;
} }