[web] Simplify `return` value of `changeThreadSettingsAction`
ClosedPublic
Actions

Authored by • abosh on Aug 23 2022, 2:34 PM.

Details

Reviewers

tomek
atul

Commits

rCOMM669f84ba59ec: [web] Simplify `return` value of `changeThreadSettingsAction`

Summary

Noticed this when reading through @tomek's feedback on D4416 when requesting review on D4931. Looks like I forgot to add this in after he accepted!

Test Plan

Flow, @tomek's feedback

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• abosh created this revision.Aug 23 2022, 2:34 PM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 23 2022, 2:34 PM

• abosh edited the summary of this revision. (Show Details)Aug 23 2022, 2:34 PM

Harbormaster completed remote builds in B11557: Diff 15892.Aug 23 2022, 2:43 PM

• abosh requested review of this revision.Aug 23 2022, 2:43 PM

atul accepted this revision.Aug 25 2022, 10:16 PM

This revision is now accepted and ready to land.Aug 25 2022, 10:16 PM

Closed by commit rCOMM669f84ba59ec: [web] Simplify `return` value of `changeThreadSettingsAction` (authored by • abosh). · Explain WhyAug 26 2022, 10:28 AM

This revision was automatically updated to reflect the committed changes.

• abosh added a commit: rCOMM669f84ba59ec: [web] Simplify `return` value of `changeThreadSettingsAction`.

Revision Contents
Changeset List

Path

Size

web/

modals/

threads/

settings/

thread-settings-general-tab.react.js

3 lines

Diff 15892

View Options

web/modals/threads/settings/thread-settings-general-tab.react.js

This file was added.

				// @flow

				import * as React from 'react';

				function CommLogo(): React.Node {
				return (
				<svg
				width="50"
				height="50"
				viewBox="0 0 51 50"
				fill="none"
				xmlns="http://www.w3.org/2000/svg"
				>
				<circle cx="25.9641" cy="25.4667" r="25" fill="#0A0A0A" />
				<path
				d="M26.7559 40.543C24.7029 40.543 22.8524 40.2329 21.2042 39.6126C19.556 38.9641 18.1537 38.0196 16.9971 36.7791C15.8405 35.5103 14.9441 33.9456 14.308 32.0847C13.6718 30.1957 13.3538 27.9966 13.3538 25.4873C13.3538 23.0062 13.6718 20.8071 14.308 18.8899C14.9441 16.9444 15.8405 15.3233 16.9971 14.0263C18.1537 12.7012 19.556 11.7003 21.2042 11.0237C22.8524 10.347 24.7029 10.0087 26.7559 10.0087C29.5607 10.0087 31.8739 10.5726 33.6955 11.7003C35.5172 12.7999 36.9774 14.5479 38.0762 16.9444L32.3944 19.8203C31.9895 18.5797 31.3534 17.5929 30.486 16.8599C29.6474 16.0986 28.4041 15.718 26.7559 15.718C24.8186 15.718 23.2572 16.3383 22.0717 17.5788C20.9151 18.7912 20.3368 20.5674 20.3368 22.9075V27.6442C20.3368 29.9843 20.9151 31.7746 22.0717 33.0152C23.2572 34.2275 24.8186 34.8337 26.7559 34.8337C28.3752 34.8337 29.6619 34.4108 30.6161 33.5649C31.5992 32.6909 32.3221 31.6477 32.7847 30.4354L38.1629 33.4804C37.0352 35.7359 35.5461 37.4839 33.6955 38.7245C31.8739 39.9368 29.5607 40.543 26.7559 40.543Z"
				fill="white"
				/>
				</svg>
				);
				}

				export default CommLogo;

[web] Simplify `return` value of `changeThreadSettingsAction`ClosedPublicActions