[services] Use `[[ ]]` instead of `[ ]` in `test_service.sh`
ClosedPublic
Actions

Authored by • abosh on Jul 5 2022, 1:06 PM.

Details

Reviewers

ashoat
atul
tomek

Commits

rCOMMdf30cb109a8b: [services] Use `[[ ]]` instead of `[ ]` in `test_service.sh`

Summary

This is the final diff needed to make brackets consistent in bash scripts.

Test Plan

@ashoat's close reading and this git grep command:

The command may be confusing to parse, so I plugged it into Regex101:

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• abosh created this revision.Jul 5 2022, 1:06 PM

Herald added subscribers: • karol, • adrian. · View Herald TranscriptJul 5 2022, 1:06 PM

• abosh edited the test plan for this revision. (Show Details)Jul 5 2022, 1:06 PM

• abosh edited the test plan for this revision. (Show Details)Jul 5 2022, 1:10 PM

• abosh edited the test plan for this revision. (Show Details)

• abosh mentioned this in D4450: [services] Clean up `test_service.sh`.Jul 5 2022, 1:13 PM

Harbormaster completed remote builds in B10308: Diff 14212.Jul 5 2022, 1:19 PM

• abosh requested review of this revision.Jul 5 2022, 1:19 PM

ashoat accepted this revision.Jul 5 2022, 1:22 PM

This revision is now accepted and ready to land.Jul 5 2022, 1:22 PM

atul accepted this revision.Jul 5 2022, 1:22 PM

Closed by commit rCOMMdf30cb109a8b: [services] Use `[[ ]]` instead of `[ ]` in `test_service.sh` (authored by • abosh). · Explain WhyJul 5 2022, 1:32 PM

This revision was automatically updated to reflect the committed changes.

• abosh added a commit: rCOMMdf30cb109a8b: [services] Use `[[ ]]` instead of `[ ]` in `test_service.sh`.

Revision Contents
Changeset List

Path

Size

services/

scripts/

test_service.sh

2 lines

Diff 14215

View Options

services/scripts/test_service.sh

[services] Use `[[ ]]` instead of `[ ]` in `test_service.sh`ClosedPublicActions