[keyserver] Clean up `deploy.sh`
AbandonedPublic
Actions

Authored by • abosh on Jul 7 2022, 8:17 AM.

Details

Reviewers

ashoat
atul
tomek

Summary

Relevant Linear issue here. More details in inline comments below.

Test Plan

ShellCheck, close reading.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• abosh created this revision.Jul 7 2022, 8:17 AM

Herald added a subscriber: • adrian. · View Herald TranscriptJul 7 2022, 8:17 AM

• abosh added inline comments.Jul 7 2022, 8:20 AM

keyserver/bash/deploy.sh
13	Use var=$(command) to assign output (or quote to assign string).
19	Use $(...) notation instead of legacy backticked ...
51	Double quote to prevent globbing and word splitting.
51	This is more concise and eliminates the need for the `grep` command.

Harbormaster completed remote builds in B10376: Diff 14284.Jul 7 2022, 8:53 AM

• abosh requested review of this revision.Jul 7 2022, 8:53 AM

Looks good to me, adding @ashoat as blocking since I've never actually run this script and he probably has more context

This revision is now accepted and ready to land.Jul 7 2022, 9:02 AM

atul added 1 blocking reviewer(s): ashoat.Jul 7 2022, 9:03 AM

This revision now requires review to proceed.Jul 7 2022, 9:03 AM

We don't use this script anymore, we're using Docker in production now. Probably would be best to just delete the script

This revision now requires changes to proceed.Jul 7 2022, 7:52 PM

• abosh mentioned this in D4484: [keyserver] Delete `deploy.sh`.Jul 8 2022, 7:21 AM

In D4477#127356, @ashoat wrote:

We don't use this script anymore, we're using Docker in production now. Probably would be best to just delete the script

Got it. Just put up D4484 to do that, closing this revision.

• abosh mentioned this in rCOMM7cac76eb3261: [keyserver] Delete `deploy.sh`.Jul 8 2022, 8:27 AM