Paths

Table of Contentst

Differential D4511

[services] Tunnelbroker - Change `AmqpManager.send()` method arguments to use `MessageItem`
ClosedPublic
Actions

Authored by • max on Jul 12 2022, 6:44 PM.

Tags

None

Referenced Files

	F3301694: D4511.diff
	Mon, Nov 18, 3:27 AM

	Unknown Object (File)
	Sat, Nov 9, 11:35 AM

	Unknown Object (File)
	Fri, Nov 8, 8:36 PM

	Unknown Object (File)
	Fri, Nov 8, 8:36 PM

	Unknown Object (File)
	Fri, Nov 8, 8:36 PM

	Unknown Object (File)
	Fri, Nov 8, 8:36 PM

	Unknown Object (File)
	Fri, Nov 8, 8:36 PM

	Unknown Object (File)
	Tue, Nov 5, 2:05 AM

Subscribers

Details

Reviewers

• karol
tomek

Commits

rCOMM1b12045ad984: [services] Tunnelbroker - Change `AmqpManager.send()` method arguments to use…

Summary

This diff introducing changes in AmqpManager.send() method to use MessageItem instead of arguments list.

Linear task: ENG-1214

Test Plan

Run tests from D4512

Diff Detail

Repository

Branch

add-notifs-to-config

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• max created this revision.Jul 12 2022, 6:44 PM

• max held this revision as a draft.

Herald added subscribers: • abosh, • karol, atul and 3 others. · View Herald TranscriptJul 12 2022, 6:44 PM

• max edited the summary of this revision. (Show Details)Jul 12 2022, 6:44 PM

Rebase on master.

• max published this revision for review.Jul 12 2022, 6:48 PM

• max added reviewers: • karol, tomek.

Harbormaster completed remote builds in B10474: Diff 14421.Jul 12 2022, 6:56 PM

Harbormaster completed remote builds in B10475: Diff 14422.Jul 12 2022, 6:59 PM

• max mentioned this in D4512: [services] Tunnelbroker - Change `AmqpManager.send()` method arguments to use `MessageItem` in tests.Jul 13 2022, 2:49 AM

• max added a child revision: D4512: [services] Tunnelbroker - Change `AmqpManager.send()` method arguments to use `MessageItem` in tests.Jul 13 2022, 2:50 AM

• max edited the test plan for this revision. (Show Details)

tomek accepted this revision.Jul 18 2022, 7:11 AM

This revision is now accepted and ready to land.Jul 18 2022, 7:11 AM

tomek added inline comments.Jul 18 2022, 7:13 AM

services/tunnelbroker/src/Amqp/AmqpManager.cpp
114–115 ↗	(On Diff #14422)	We were taking `payload` by value and now we take `message` by reference - please make sure that everything will work correctly

Fixing a message access by pointer.

Harbormaster failed remote builds in B10804: Diff 14857!Jul 25 2022, 7:12 AM

Please, make sure the CI doesn't fail.

This revision now requires changes to proceed.Jul 25 2022, 7:54 AM

In D4511#132413, @karol wrote:

Please, make sure the CI doesn't fail.

Sure! I saw the CI error. Thanks for pinging. Btw, when we are trying to land something with the build error the arc will throw attention, so we will not miss this anyway.

Fixing a nit in a function parameter.

Harbormaster completed remote builds in B10814: Diff 14875.Jul 25 2022, 10:34 AM

• karol accepted this revision.Jul 26 2022, 4:09 AM

This revision is now accepted and ready to land.Jul 26 2022, 4:09 AM

Closed by commit rCOMM1b12045ad984: [services] Tunnelbroker - Change `AmqpManager.send()` method arguments to use… (authored by • max). · Explain WhyJul 26 2022, 4:23 AM

This revision was automatically updated to reflect the committed changes.

• max added a commit: rCOMM1b12045ad984: [services] Tunnelbroker - Change `AmqpManager.send()` method arguments to use….

• max mentioned this in rCOMMbc11d879493d: [services] Tunnelbroker - Change `AmqpManager.send()` method arguments to use….

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

src/

Amqp/

8 lines

AmqpManager.cpp

15 lines

Service/

TunnelbrokerServiceImpl.cpp

6 lines

Diff 14421

services/tunnelbroker/src/Amqp/AmqpManager.h

Loading...

services/tunnelbroker/src/Amqp/AmqpManager.cpp

Loading...

services/tunnelbroker/src/Service/TunnelbrokerServiceImpl.cpp

Loading...