Paths

Table of Contentst

-
services/terraform/
-
terraform/
-
dynamodb.tf

[services] add dynamodb tables for identity service to terraform
ClosedPublic
Actions

Authored by varun on Jul 13 2022, 11:44 AM.

Details

Reviewers

• max
tomek
• karol

Commits

rCOMM6912b58e7f20: [services] add dynamodb tables for identity service to terraform

Summary

These tables already exist in DynamoDB but they should still be added here so we can manage them with Terraform.

Test Plan

ran terraform validate

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Jul 13 2022, 11:44 AM

Herald added subscribers: • abosh, atul, • adrian, ashoat. · View Herald TranscriptJul 13 2022, 11:44 AM

Harbormaster completed remote builds in B10497: Diff 14444.Jul 13 2022, 11:56 AM

varun requested review of this revision.Jul 13 2022, 11:56 AM

• max requested changes to this revision.Jul 14 2022, 6:39 AM

• max added inline comments.

services/terraform/dynamodb.tf
165–166 ↗	(On Diff #14444)	I think we have a convention for using the plurals in our table names. By the way, you already use the plural name in the' identity-tokens' table below.

This revision now requires changes to proceed.Jul 14 2022, 6:39 AM

varun requested review of this revision.Jul 14 2022, 7:26 AM

varun added inline comments.

services/terraform/dynamodb.tf
165–166 ↗	(On Diff #14444)	`registration` actually is plural. `registrations` is also a plural form, but it sounds unnatural. https://www.wordhippo.com/what-is/the-plural-of/registration.html

• max accepted this revision.Jul 14 2022, 7:50 AM

• max added inline comments.

services/terraform/dynamodb.tf
165–166 ↗	(On Diff #14444)	`registration` actually is plural. `registrations` is also a plural form, but it sounds unnatural. https://www.wordhippo.com/what-is/the-plural-of/registration.html Oh, sorry about that )

tomek accepted this revision.Jul 19 2022, 1:40 AM

This revision is now accepted and ready to land.Jul 19 2022, 1:40 AM

ashoat mentioned this in D4559: [services] rename registration table to users table.Jul 19 2022, 8:33 AM

Closed by commit rCOMM6912b58e7f20: [services] add dynamodb tables for identity service to terraform (authored by varun). · Explain WhyJul 19 2022, 11:23 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM6912b58e7f20: [services] add dynamodb tables for identity service to terraform.

varun added inline comments.Jul 19 2022, 11:24 AM

services/terraform/dynamodb.tf
166	This change is intentional

Revision Contents
Changeset List

Path

Size

services/

terraform/

dynamodb.tf

30 lines

Diff 14658

View Options

services/terraform/dynamodb.tf

	FROM commapp/services-base:1.1			FROM commapp/services-base:1.1

	RUN apt-get update && \			RUN apt-get update && \
	apt-get install -y uuid-dev && \			apt-get install -y uuid-dev && \
	rm -rf /var/lib/apt/lists/*			rm -rf /var/lib/apt/lists/*

	ARG COMM_TEST_SERVICES			ARG COMM_TEST_SERVICES
	ARG COMM_SERVICES_DEV_MODE			ARG COMM_SERVICES_DEV_MODE

	ENV COMM_TEST_SERVICES=${COMM_TEST_SERVICES}			ENV COMM_TEST_SERVICES=${COMM_TEST_SERVICES}
	ENV COMM_SERVICES_DEV_MODE=${COMM_SERVICES_DEV_MODE}			ENV COMM_SERVICES_DEV_MODE=${COMM_SERVICES_DEV_MODE}

	WORKDIR /transferred			WORKDIR /transferred

	COPY native/cpp/CommonCpp/grpc/protos/backup.proto native/cpp/CommonCpp/grpc/protos/blob.proto protos/			COPY native/cpp/CommonCpp/grpc/protos/backup.proto native/cpp/CommonCpp/grpc/protos/blob.proto protos/
	COPY services/backup/docker/ scripts/
	COPY services/lib/ .			COPY services/lib/ .
	COPY services/backup/ .			COPY services/backup/ .

	RUN scripts/build_server.sh			RUN scripts/build_server.sh

	CMD if [ "$COMM_TEST_SERVICES" -eq 1 ]; then scripts/run_tests.sh; else scripts/run_server.sh; fi			CMD if [ "$COMM_TEST_SERVICES" -eq 1 ]; then scripts/run_tests.sh; else scripts/run_server.sh; fi

[services] add dynamodb tables for identity service to terraformClosedPublicActions