[services] add dynamodb tables for identity service to terraform
ClosedPublic
Actions

Authored by varun on Jul 13 2022, 11:44 AM.

Details

Reviewers

Commits

Summary

These tables already exist in DynamoDB but they should still be added here so we can manage them with Terraform.

Test Plan

ran terraform validate

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

varun requested review of this revision.Jul 13 2022, 11:56 AM

• max requested changes to this revision.Jul 14 2022, 6:39 AM

• max added inline comments.

services/terraform/dynamodb.tf
165–166 ↗	(On Diff #14444)	I think we have a convention for using the plurals in our table names. By the way, you already use the plural name in the' identity-tokens' table below.

This revision now requires changes to proceed.Jul 14 2022, 6:39 AM

varun requested review of this revision.Jul 14 2022, 7:26 AM

varun added inline comments.

services/terraform/dynamodb.tf
165–166 ↗	(On Diff #14444)	`registration` actually is plural. `registrations` is also a plural form, but it sounds unnatural. https://www.wordhippo.com/what-is/the-plural-of/registration.html

• max added inline comments.

services/terraform/dynamodb.tf
165–166 ↗	(On Diff #14444)	`registration` actually is plural. `registrations` is also a plural form, but it sounds unnatural. https://www.wordhippo.com/what-is/the-plural-of/registration.html Oh, sorry about that )