Replaced single quote with apostrophe in user-displayed text. Wasn't sure the best way to title this, but basically this diff only replaces the single quotes in text that can get displayed in a modal, the app, or an error message that isn't an invariant.
Details
Details
- Reviewers
atul - Commits
- rCOMM4cdbb7da56d5: [chore] Replace `'` with `’` in user-displayed text
Used this regex to search for all instances of ' surrounded by "":
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/facts/genesis.json | ||
|---|---|---|
| 1 ↗ | (On Diff #14503) | Not sure where this or testers.json is used anymore, but it's human-readable/user-displayed text somewhere, so I changed it. |
Comment Actions
Seems reasonable. It might be hard to keep it this way in the codebase since the ' key is a single quote in code editors.
There's probably some way to enforce the rule, but I don't think it really matters enough to go through that effort.