Quick change I noticed before working on ENG-1733. This uses apostrophes and quotation marks that are slanted instead of the straight ones since this is user-displayed text. Also removes string concatenation from return value of robotext(...) since it's slower.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- master
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Is it consistent with all the usages in the app? If we decide to use slanted signs, we should make sure to use the same version through the app.
Comment Actions
I agree this is a good change, and I think we could land this if we create a starter task for somebody else to find all of the other locations this occurs in the codebase
Comment Actions
Addressed @tomek's feedback:
Is it consistent with all the usages in the app? If we decide to use slanted signs, we should make sure to use the same version through the app.
Turns out I had actually tried tackling this in D4541, the only issue being the regex I used to match was ".*'.*", and I forgot to also match `.*'.*` (strings that are encapsulated with backticks).
Fixed all usages of ' and "" in the app by searching using the regex with backticks to find all strings with backticks that contained ' or "" symbols in user displayed text. Replaced each usage with slanted counterparts.
Comment Actions
I think you should also search for '.*\'.*' - I would be surprised if we have things like this, but it's better to be sure.