Add comments in messageTypes definition to clarify the difference between CREATE_SUB_THREAD and
CREATE_THREAD/CREATE_SIDEBAR. The CREATE_SUB_THREAD is now referencing only creating subthreads, but it used to also reference
creating sidebars. This can be observed in the database. For this reason this usecase has to be acknowledged in the code (eg.
in lib/shared/messages/create-sub-thread-message-spec.js).
Details
Details
- Reviewers
ashoat tomek - Commits
- rCOMMd9fd02a7d10a: [lib] Add comments in messageTypes definition
Check if the types actually correspond to specified chat types by changing the robotext displayed to the user based
on them.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
It's always good to try and stay consistent with the style in the file you're editing. In this case, you can see that there is a comment above UNSUPPORTED that looks a little different:
- The comment appears above instead of beside the code
- The line length is limited to 80 chars (this is actually a universal rule in our codebase)
- The comment starts with a capital letter