Page MenuHomePhabricator
Differential D4609

[web] Introduce `SidebarList` component
ClosedPublic
Actions

Authored by • jacek on Jul 22 2022, 8:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 9, 4:59 PM
Unknown Object (File)
Sat, Nov 9, 3:49 PM
Unknown Object (File)
Sat, Nov 9, 11:56 AM
Unknown Object (File)
Sat, Nov 9, 9:08 AM
Unknown Object (File)
Oct 17 2024, 3:37 PM
Unknown Object (File)
Oct 7 2024, 4:07 PM
Unknown Object (File)
Oct 7 2024, 4:07 PM
Unknown Object (File)
Oct 7 2024, 4:07 PM
View All 89 Files
Subscribers
• abosh
• adrian
ashoat

Details

Reviewers
tomek
atul
ashoat
Commits
rCOMM0c0089870261: [web] Introduce `SidebarList` component
Summary

Introduce component displaying list of sidebars in Sidebars modal.

Screenshot_Google Chrome_2022-07-22_173057.png (666×472 px, 38 KB)

Screenshot_Google Chrome_2022-07-25_151232.png (670×464 px, 20 KB)

Test Plan

The component will be used in Sidebars Modal after next diff.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• jacek created this revision.Jul 22 2022, 8:22 AM
Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptJul 22 2022, 8:22 AM
• jacek edited the summary of this revision. (Show Details)Jul 22 2022, 8:31 AM
• jacek added a child revision: D4610: [web] Introduce `SidebarsModal`.
• jacek added a parent revision: D4608: [web] Introduce `Sidebar` component.
Harbormaster completed remote builds in B10776: Diff 14817.Jul 22 2022, 8:34 AM
• jacek requested review of this revision.Jul 22 2022, 8:35 AM
tomek accepted this revision.Jul 25 2022, 6:02 AM
tomek added a reviewer: ashoat.

Could you also share a screenshot with empty sidebars?

Adding @ashoat as the copy is introduced.

web/modals/threads/sidebars/sidebar-list.react.js
29 ↗(On Diff #14817)

Overall I'm not a big fan of checking truthiness when the intention is to check the length. I think we should express our intention.

• jacek edited the summary of this revision. (Show Details)Jul 25 2022, 6:12 AM
ashoat accepted this revision.Jul 25 2022, 6:28 AM
ashoat added inline comments.
web/modals/threads/sidebars/sidebar-list.react.js
32 ↗(On Diff #14817)

Can we use a period instead of an exclamation mark at the end?

This revision is now accepted and ready to land.Jul 25 2022, 6:28 AM
• jacek updated this revision to Diff 14844.Jul 25 2022, 6:39 AM

Replaced "!" with "." and address Tomek's suggestion

Harbormaster completed remote builds in B10796: Diff 14844.Jul 25 2022, 6:52 AM
Closed by commit rCOMM0c0089870261: [web] Introduce `SidebarList` component (authored by • jacek). · Explain WhyJul 26 2022, 8:30 AM
This revision was automatically updated to reflect the committed changes.
• jacek added a commit: rCOMM0c0089870261: [web] Introduce `SidebarList` component.

Revision Contents
Changeset List

PathSize
web/
modals/
threads/
sidebars/
39 lines
11 lines
1 line

Diff 14988

View Options

web/modals/threads/sidebars/sidebar-list.react.js

Loading...
View Options

web/modals/threads/sidebars/sidebars-modal.css

Loading...
View Options

web/theme.css

Loading...