Page MenuHomePhabricator

[lib] Rename `locallyUnique...` to `pending...` to improve readability
ClosedPublic

Authored by jacek on Jul 26 2022, 7:31 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 15, 5:53 PM
Unknown Object (File)
Fri, Nov 8, 3:03 PM
Unknown Object (File)
Fri, Nov 8, 3:03 PM
Unknown Object (File)
Fri, Nov 8, 3:01 PM
Unknown Object (File)
Fri, Nov 8, 2:59 PM
Unknown Object (File)
Sep 26 2024, 11:40 PM
Unknown Object (File)
Sep 11 2024, 5:44 AM
Unknown Object (File)
Sep 11 2024, 5:44 AM

Details

Summary

Follow-up after D4443. The diff reverts renaming pending to locallyUnique made a few months ago.
Linear: https://linear.app/comm/issue/ENG-1374/rename-locallyuniquethreadid-to-pendingthreadid

Test Plan

Web and mobile apps build correctly and work as before. Confirmed, that features using locallyUnique/pending IDs still works correctly - e.g. thread creation and storing drafts for pending threads.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Looks good.

(Also searched for each of the new names in the codebase to make sure there weren't any collisions, and couldn't find any)

This revision is now accepted and ready to land.Jul 26 2022, 11:33 AM