[services] Blob - PullBackupReactor - Simplify write response logic
ClosedPublic
Actions

Authored by • karol on Jul 27 2022, 1:11 PM.

Details

Reviewers

tomek

Commits

rCOMM3801e446e5ed: [services] Blob - PullBackupReactor - Simplify write response logic

Summary

Depends on D4649

I spotted that there's a redundant call of prepareDataChunkWithPadding and the logic of the PullBackupReactor::writeResponse can be simplified.

Test Plan

cd services
yarn run-backup-service-in-sandbox

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• karol created this revision.Jul 27 2022, 1:11 PM

Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJul 27 2022, 1:11 PM

• karol edited the summary of this revision. (Show Details)Jul 27 2022, 1:14 PM

• karol edited the test plan for this revision. (Show Details)

• karol added a reviewer: tomek.

• karol added a parent revision: D4649: [services] Blob - Get Reactor - Fix initialize logic.

Harbormaster completed remote builds in B10909: Diff 15009.Jul 27 2022, 1:21 PM

• karol requested review of this revision.Jul 27 2022, 1:21 PM

tomek accepted this revision.Jul 28 2022, 10:40 AM

This revision is now accepted and ready to land.Jul 28 2022, 10:40 AM

Closed by commit rCOMM3801e446e5ed: [services] Blob - PullBackupReactor - Simplify write response logic. · Explain WhyAug 2 2022, 10:05 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM3801e446e5ed: [services] Blob - PullBackupReactor - Simplify write response logic.

Revision Contents
Changeset List

Path

Size

services/

backup/

src/

Reactors/

server/

PullBackupReactor.cpp

3 lines

Diff 15202

View Options

services/backup/src/Reactors/server/PullBackupReactor.cpp

[services] Blob - PullBackupReactor - Simplify write response logicClosedPublicActions