Remove database acces upon rescinding
AbandonedPublic
Actions

Authored by marcin on Aug 1 2022, 9:20 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, May 11, 10:22 AM

	Unknown Object (File)
	Apr 6 2024, 12:58 PM

	Unknown Object (File)
	Apr 4 2024, 7:01 PM

	Unknown Object (File)
	Apr 4 2024, 7:01 PM

	Unknown Object (File)
	Apr 4 2024, 7:00 PM

	Unknown Object (File)
	Apr 1 2024, 1:48 AM

	Unknown Object (File)
	Mar 2 2024, 6:49 AM

	Unknown Object (File)
	Feb 28 2024, 11:36 PM

Subscribers

Details

Reviewers

atul

Summary

This differential removes lines that access database when receiving rescind

Test Plan

The application should built and work as previously, though we will not update SQLite unread status of the thread that is being rescinded

Diff Detail

Repository

rCOMM Comm

Branch

marcin/eng-1464

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Aug 1 2022, 9:20 AM

Herald added subscribers: • abosh, • adrian, tomek, ashoat. · View Herald TranscriptAug 1 2022, 9:20 AM

Harbormaster completed remote builds in B11007: Diff 15143.Aug 1 2022, 9:34 AM

marcin requested review of this revision.Aug 1 2022, 9:34 AM

Will include these changes in the "Changes before release" patch and make a new staff release.

Included in patch for build 140: https://github.com/CommE2E/comm/commit/20c8d41d0ed2dec55ea7925e288ab5365f8337d1

atul accepted this revision.Aug 1 2022, 12:15 PM

This revision is now accepted and ready to land.Aug 1 2022, 12:15 PM

marcin abandoned this revision.Apr 12 2024, 4:45 AM

The only purpose of this diff was to create release that could potentially fix the crash https://linear.app/comm/issue/ENG-1464/ios-build-137-crashes

Revision Contents
Changeset List

Path

Size

native/

ios/

Comm/

AppDelegate.mm

8 lines

Diff 15143

View Options

native/ios/Comm/AppDelegate.mm

Remove database acces upon rescindingAbandonedPublicActions