Page MenuHomePhabricator

[web] Align `MessageTimestampTooltip` under `MessageTooltip`
ClosedPublic

Authored by abosh on Aug 1 2022, 1:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 16, 6:29 PM
Unknown Object (File)
Mon, Dec 16, 6:29 PM
Unknown Object (File)
Mon, Dec 16, 12:52 AM
Unknown Object (File)
Fri, Dec 6, 6:09 PM
Unknown Object (File)
Tue, Dec 3, 7:41 PM
Unknown Object (File)
Nov 8 2024, 3:23 PM
Unknown Object (File)
Nov 8 2024, 3:23 PM
Unknown Object (File)
Nov 8 2024, 3:22 PM
Subscribers

Details

Summary

Part of a stack of diffs to fix the timestamp bug, related Linear issue here.

This diff moves the timestamp tooltip below the message tooltip (with the reply and create thread buttons). Handling other front-end changes like color will be handled in subsequent diffs in this stack, this diff is just focused on aligning the tooltip correctly.

Depends on D4481.

Test Plan

Tested on Chrome/Safari and looks as expected.
Chrome:

Safari:

Additional stills:

image.png (240×578 px, 19 KB)

image.png (172×396 px, 16 KB)

image.png (350×1 px, 68 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

web/chat/message-timestamp-tooltip.react.js
22–24 ↗(On Diff #15168)

Why were the values of these arrays swapped?

In the old tooltip logic, the tooltip for a composed viewer message, i.e., a message that you had written, would appear on the BOTTOM_RIGHT of the message:

image.png (176×268 px, 28 KB)

Similarly, in the old logic, the tooltip for a noncomposed or nonviewer message would appear on the LEFT of the message:

image.png (166×430 px, 19 KB)

However, as can be seen in the videos, this diff flips that logic to match prod. On prod, tooltips for composed viewer message appears on the LEFT of the message:

image.png (282×544 px, 27 KB)

And noncomposed message appears on the right:

image.png (300×1 px, 46 KB)

I kept it BOTTOM_RIGHT since I didn't want to break the old tooltip logic and introduce any regressions, but BOTTOM_RIGHT can probably be made RIGHT in the future.

This revision is now accepted and ready to land.Aug 4 2022, 8:47 AM