Adjust getPotentialMemberItems logic to match permissions on server side.
Linear issue: https://linear.app/comm/issue/ENG-1200/creating-thread-with-non-friend-user-is-blocked-on-front-end-and
Details
Details
Tested the change by trying to add friends/non-friends to community root/community [open|secret] subchannel/sidebars. It is possible to add any community member to community subchannel, and only friends to community.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/shared/search-utils.js | ||
|---|---|---|
| 35–36 ↗ | (On Diff #15251) | Seeing this logic duplicated here is concerning. I looked into how we determine this on the keyserver side, and found that it boils down to the function getContainingThreadID in lib. Can we make sure to use the same codepath here? That function returns an ID instead of a ThreadInfo, but I'm sure there's a way to avoid duplicating the logic. |
Comment Actions
This looks great!!
| lib/shared/search-utils.js | ||
|---|---|---|
| 158 ↗ | (On Diff #15313) | I don't think the double negation is necessary on parentThreadInfo |