[keyserver] Clean up `run-prod.sh` using ShellCheck
ClosedPublic
Actions

Authored by • abosh on Aug 2 2022, 8:59 AM.

Details

Reviewers

atul
• jon
tomek
ashoat

Commits

rCOMM04fff33b364e: [keyserver] Clean up `run-prod.sh` using ShellCheck

Summary

Related Linear issue here. This is part of a set of diffs that will allow ShellCheck to be added to the CI. See inline comments for specific details of the ShellCheck error/warning output.

Test Plan

ShellCheck.

Additionally, this script is run during the keyserver build so if that workflow continues to pass CI we can reasonably assume that the script continues to work as expected.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• abosh created this revision.Aug 2 2022, 8:59 AM

Herald added a subscriber: • adrian. · View Herald TranscriptAug 2 2022, 8:59 AM

• abosh added inline comments.Aug 2 2022, 9:00 AM

keyserver/bash/run-prod.sh
8 ↗	(On Diff #15216)	Can't follow non-constant source. Use a directive to specify location.

Harbormaster completed remote builds in B11054: Diff 15216.Aug 2 2022, 9:12 AM

• abosh requested review of this revision.Aug 2 2022, 9:12 AM

• abosh edited the test plan for this revision. (Show Details)Aug 2 2022, 9:19 AM

• abosh retitled this revision from [keyserver] Clean up `run-prod.sh` to [keyserver] Clean up `run-prod.sh` using ShellCheck.Aug 2 2022, 9:30 AM

• abosh edited the summary of this revision. (Show Details)

atul accepted this revision.Aug 2 2022, 10:28 AM

atul added inline comments.

keyserver/bash/run-prod.sh
8 ↗	(On Diff #15216)	Thanks for sharing the link. So it looks like the relevant part is: If you don't care that ShellCheck is unable to account for the file, specify `# shellcheck source=/dev/null`. which makes sense.