[services] Clean up `build_service.sh` using ShellCheck
ClosedPublic
Actions

Authored by • abosh on Aug 2 2022, 9:49 AM.

Details

Reviewers

atul
• jon
tomek
ashoat

Commits

rCOMM1e62e4dff75c: [services] Clean up `build_service.sh` using ShellCheck

Summary

Related Linear issue here. This is part of a set of diffs that will allow ShellCheck to be added to the CI. See inline comments for specific details of the ShellCheck error/warning output.

Test Plan

ShellCheck

Additionally, this script is run during the Backup, Blob, and Tunnelbroker builds so if those workflows continue to pass CI we can reasonably assume that the script continues to work as expected.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• abosh created this revision.Aug 2 2022, 9:49 AM

Herald added subscribers: • karol, • adrian. · View Herald TranscriptAug 2 2022, 9:49 AM

Harbormaster completed remote builds in B11062: Diff 15227.Aug 2 2022, 9:59 AM

• abosh requested review of this revision.Aug 2 2022, 9:59 AM

• abosh added inline comments.Aug 2 2022, 10:00 AM

services/lib/docker/build_service.sh
11–13 ↗	(On Diff #15227)	(warning): This ln has no destination. Check the arguments, or specify '.' explicitly. Note that @jon removes these lines in D4671, but since that hasn't been landed yet and this is blocking adding ShellCheck to the CI, I've made this change here.

• abosh edited the test plan for this revision. (Show Details)Aug 2 2022, 10:51 AM

I don't have much context on this script I think, and I'm a bad choice for a first-pass reviewer except for cases listed here

ashoat added 1 blocking reviewer(s): • jon.Aug 2 2022, 11:07 AM

Note that @jon removes these lines in D4671, but since that hasn't been landed yet and this is blocking adding ShellCheck to the CI, I've made this change here.

Lets leave a note on that diff so it's clear that it needs to be rebased before it can be landed.

atul accepted this revision.Aug 2 2022, 11:21 AM

I'm fine with rebasing

This revision is now accepted and ready to land.Aug 2 2022, 11:54 AM

Closed by commit rCOMM1e62e4dff75c: [services] Clean up `build_service.sh` using ShellCheck (authored by • abosh). · Explain WhyAug 2 2022, 2:23 PM

This revision was automatically updated to reflect the committed changes.

• abosh added a commit: rCOMM1e62e4dff75c: [services] Clean up `build_service.sh` using ShellCheck.