[keyserver] Create messages for open GENESIS subchannels
ClosedPublic
Actions

Authored by ashoat on Aug 11 2022, 8:16 AM.

Details

Reviewers

atul

Commits

rCOMM2d9843718e15: [keyserver] Create messages for open GENESIS subchannels

Summary

To avoid spammming everybody, today we don't create messages when a subchannel of GENESIS is created.

But for the seed round party, we want to create an open subchannel of GENESIS that everybody can access. To make it easy to access, we want to have a message appear in GENESIS about the channel.

This diff makes it so the messages are still created for open subchannels of GENESIS. The only way for an open subchannel of GENESIS to be created is for me (@ashoat) to do it manually, so this is safe.

Test Plan

I tested this in my local environment and it created a message (but only when combined with the hacks listed here)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Aug 11 2022, 8:16 AM

Herald added subscribers: • abosh, • adrian, tomek. · View Herald TranscriptAug 11 2022, 8:16 AM

ashoat added a child revision: D4809: [keyserver] Introduce make-channel-private.js script.Aug 11 2022, 8:18 AM

Harbormaster completed remote builds in B11302: Diff 15551.Aug 11 2022, 8:25 AM

ashoat requested review of this revision.Aug 11 2022, 8:25 AM

atul accepted this revision.Aug 11 2022, 8:38 AM

This revision is now accepted and ready to land.Aug 11 2022, 8:38 AM

Looks good

(Off-topic but it seems like one day it'd be good to break apart the queries and logic in createThread(...) into separate functions so individual pieces of logic like this can be unit tested etc)

Closed by commit rCOMM2d9843718e15: [keyserver] Create messages for open GENESIS subchannels (authored by ashoat). · Explain WhyAug 11 2022, 10:30 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM2d9843718e15: [keyserver] Create messages for open GENESIS subchannels.