Page MenuHomePhabricator

[native] Rename `swmansion.ttf` to `SWMansion.ttf`
AbandonedPublic

Authored by abosh on Aug 15 2022, 1:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 9, 12:02 PM
Unknown Object (File)
Oct 2 2024, 9:37 PM
Unknown Object (File)
Aug 21 2024, 4:27 PM
Unknown Object (File)
Aug 8 2024, 2:50 PM
Unknown Object (File)
Jul 4 2024, 11:54 AM
Unknown Object (File)
Jun 13 2024, 9:53 AM
Unknown Object (File)
Apr 20 2024, 3:25 PM
Unknown Object (File)
Apr 7 2024, 1:46 AM

Details

Reviewers
atul
Summary

Context here. Renamed swmansion.ttf to SWMansion.ttf to match the capitalization of CommIcon introduced in D4829.

Test Plan

git grep 'swmansion.ttf', no results. Also rebuilt the entire iOS app from Xcode, although not sure if that's relevant to testing this. I figured since I was modifying Xcode files, I should make sure. In the app, all the icons/fonts looked normal.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Add file renames from swmansion.ttf to SWMansion.ttf. Only the code changes were picked up in the original diff since git treats renames as case-insensitive by default, so the renames of the files weren't part of the original commit.

atul requested changes to this revision.Aug 16 2022, 7:27 AM

Appreciate how quickly you put this up, but unfortunately I'll be recreating this file anyways so we should probably just abandon this diff.

Once recreated, both the filename and font name (which you can find in the information section of Font Book on your Mac, see below) will be in sync

Screen Shot 2022-08-16 at 10.27.50 AM.png (938×1 px, 283 KB)

This revision now requires changes to proceed.Aug 16 2022, 7:27 AM
In D4838#140143, @atul wrote:

Appreciate how quickly you put this up, but unfortunately I'll be recreating this file anyways so we should probably just abandon this diff.

Once recreated, both the filename and font name (which you can find in the information section of Font Book on your Mac, see below) will be in sync

Screen Shot 2022-08-16 at 10.27.50 AM.png (938×1 px, 283 KB)

Ok! Abandoning.