Page MenuHomePhabricator

[web] Replace `cloud-filled` icon in `ChatThreadAncestors` with `CommIcon`
ClosedPublic

Authored by atul on Aug 16 2022, 1:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 3, 7:45 PM
Unknown Object (File)
Sun, Nov 3, 7:45 PM
Unknown Object (File)
Sun, Nov 3, 7:44 PM
Unknown Object (File)
Sun, Nov 3, 7:26 PM
Unknown Object (File)
Sep 26 2024, 8:55 PM
Unknown Object (File)
Sep 26 2024, 8:55 PM
Unknown Object (File)
Sep 26 2024, 8:55 PM
Unknown Object (File)
Sep 26 2024, 8:49 PM
Subscribers

Details

Summary

Searched through codebase for usages of cloud-filled and found one instance in the ChatThreadAncestors component.

Swapped out the SWMansionIcon component for the CommIcon component.

NOTE: Going to create individual diffs for all usages of each icon for CommIcons to make the before/after clear. There are only 6 custom CommIcons so this shouldn't produce too much spam.
Test Plan
WARNING: The actual icon changed. I'm using the same cloud icon we decided with Alicja to go with on native. I strongly think we should go with the same filled cloud icon on web because A. consistency B. it looks a lot better than an open path.

Before:

Screen Shot 2022-08-16 at 3.42.02 PM.png (104×652 px, 16 KB)

After:

0e72bcde06fb91da.png (104×652 px, 16 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul edited the summary of this revision. (Show Details)
atul edited the test plan for this revision. (Show Details)
atul requested review of this revision.Aug 16 2022, 1:12 PM
WARNING: The actual icon changed. I'm using the same cloud icon we decided with Alicja to go with on native. I strongly think we should go with the same filled cloud icon on web because A. consistency B. it looks a lot better than an open path.

Thanks for noting this. I agree.

This revision is now accepted and ready to land.Aug 16 2022, 1:32 PM