Page MenuHomePhabricator

[landing] revert changes in D4510
AbandonedPublic

Authored by derek on Aug 26 2022, 2:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 1, 9:00 PM
Unknown Object (File)
Tue, Apr 30, 6:22 PM
Unknown Object (File)
Sat, Apr 6, 4:20 AM
Unknown Object (File)
Wed, Apr 3, 10:17 PM
Unknown Object (File)
Wed, Apr 3, 10:15 PM
Unknown Object (File)
Wed, Apr 3, 10:05 PM
Unknown Object (File)
Mar 8 2024, 8:36 PM
Unknown Object (File)
Feb 21 2024, 2:07 AM

Details

Summary

temporarily commenting out SIWE while we get to the bottom of the cool looking issue caused by rainbowkit
before:

image.png (1×1 px, 1 MB)

after:
image.png (1×1 px, 1 MB)

context in thread

Test Plan

ran it before commenting and after. fixes CSS issue

Diff Detail

Repository
rCOMM Comm
Branch
derek/siwe-webview
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Hmm...your before and after pics are mine. I didn't test this diff. Additionally, the after pic is just the current state of https://comm.app/, our public facing landing page. This diff broke in dev, not prod.

You should incorporate these changes, and show that the fix works with these changes.

This revision now requires changes to proceed.Aug 26 2022, 3:15 PM

Please don't comment things out. If the diff broke master it just be reverted, not commented out