Details

Reviewers

• abosh
• jacek
tomek
ashoat

Commits

rCOMM8c6cd24f7823: [lib] Introduce tests for `tMediaMessage[Photo/Video/Media]`
rCOMM7ff483ad02d6: [lib] Introduce tests for `tMediaMessage[Photo/Video/Media]`

Summary

Introduced these in previous diff (D4990).

Just some basic tests mostly as a sanity check for myself since I have minimal experience with tcomb.

Test Plan

Run these tests (they're included in CI as well)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

fix typo

atul published this revision for review.Aug 30 2022, 10:06 PM

Harbormaster completed remote builds in B11731: Diff 16121.Aug 30 2022, 10:14 PM

Harbormaster completed remote builds in B11732: Diff 16122.

• abosh edited the summary of this revision. (Show Details)Aug 31 2022, 5:13 AM

tomek accepted this revision.Aug 31 2022, 11:38 AM

This revision is now accepted and ready to land.Aug 31 2022, 11:38 AM

• abosh accepted this revision.Aug 31 2022, 4:35 PM

rebase around other diffs before landing

This revision was landed with ongoing or failed builds.Aug 31 2022, 6:41 PM

Closed by commit rCOMM7ff483ad02d6: [lib] Introduce tests for `tMediaMessage[Photo/Video/Media]`. · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM7ff483ad02d6: [lib] Introduce tests for `tMediaMessage[Photo/Video/Media]`.

Harbormaster completed remote builds in B11746: Diff 16141.Aug 31 2022, 6:47 PM

atul added a reverting change: rCOMM39367c357963: Revert "[lib] Introduce tests for `tMediaMessage[Photo/Video/Media]`".Aug 31 2022, 7:40 PM

atul reopened this revision.Aug 31 2022, 7:46 PM

This revision is now accepted and ready to land.Aug 31 2022, 7:46 PM

Closed by commit rCOMM8c6cd24f7823: [lib] Introduce tests for `tMediaMessage[Photo/Video/Media]`. · Explain WhyAug 31 2022, 7:48 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM8c6cd24f7823: [lib] Introduce tests for `tMediaMessage[Photo/Video/Media]`.

[lib] Introduce tests for `tMediaMessage[Photo/Video/Media]`
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 16150

lib/utils/validation-utils.test.js

[lib] Introduce tests for `tMediaMessage[Photo/Video/Media]`ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 16150

lib/utils/validation-utils.test.js

[lib] Introduce tests for `tMediaMessage[Photo/Video/Media]`
ClosedPublic
Actions

Revision Contents
Changeset List