removed unnecessary console logs [DISREGARD]
AbandonedPublic
Actions

Authored by ginsu on Sep 2 2022, 6:51 PM.

Details

Reviewers: None

Summary

whoops did not mean to submit this diff. was trying to update the other diff, not create a new one
resovled comments left on first diff, still stuck with attaching background color to dyanmically generated blockquote

Test Plan

At the current state the only way to see the blockquote is that there is more padding around the content; however, when the background color is implemented everything will come together nicely

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Sep 2 2022, 6:51 PM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptSep 2 2022, 6:51 PM

Harbormaster completed remote builds in B11868: Diff 16281.Sep 2 2022, 7:00 PM

ginsu requested review of this revision.Sep 2 2022, 7:00 PM

ginsu retitled this revision from removed unnecessary console logs to removed unnecessary console logs [DISREGARD].Sep 2 2022, 7:05 PM

ginsu edited the summary of this revision. (Show Details)

Instead of writing [DISREGARD], you can submit the Abandon Revision action!

ginsu abandoned this revision.Sep 2 2022, 11:46 PM

Revision Contents
Changeset List

Path

Size

web/

markdown/

rules.react.js

2 lines

Diff 16281

View Options

web/markdown/rules.react.js

	Show All 21 Lines
	a {			a {
	text-decoration: none;			text-decoration: none;
	color: #2a5db0;			color: #2a5db0;
	}			}
	img,			img,
	iframe {			iframe {
	display: block;			display: block;
	}			}
	input[type='text'],			input[type='text'],
	input[type='password'],			input[type='password'],
	textarea {			textarea {
	atulUnsubmitted Not Done Inline Actions Moving the global input styling and moving it to the input component. Then why are we keeping styles like `border` and `border-radius`? Don't these styles also affect the `<textarea>` tag? Are you sure we want to be removing these styles for that as well? Or should we break this into two separate selectors (one for `input` and another for `textarea`)? atul: > Moving the global input styling and moving it to the input component. Then why are we…
	benschacAuthorUnsubmitted Done Inline Actions Yeah, I should break these styles out a bit more. I don't think they really do anything. But you make a good point that this will also effect `textarea` elements. benschac: Yeah, I should break these styles out a bit more. I don't think they really do anything. But…
	-webkit-appearance: none;
	-moz-appearance: none;
	-webkit-border-radius: 0;
	border: 1px solid #dddddd;			border: 1px solid #dddddd;
	border-radius: 1px;			border-radius: 1px;
	font-family: var(--font-stack);			font-family: var(--font-stack);
	}			}
	:global(#react-root) {			:global(#react-root) {
	display: flex;			display: flex;
	flex-direction: column;			flex-direction: column;
	height: 100%;			height: 100%;
	▲ Show 20 Lines • Show All 243 Lines • Show Last 20 Lines

removed unnecessary console logs [DISREGARD]AbandonedPublicActions