[lib] Lowercase all reserved usernames
ClosedPublic
Actions

Authored by ashoat on Sep 7 2022, 8:08 PM.

Details

Reviewers

atul
tomek

Commits

rCOMMb061099f516f: [lib] Lowercase all reserved usernames

Summary

Somebody was able to register with the username "comm". Looked into it and found that we were checking lowercased usernames against the list, but some of the entries in the list were not lowercase.

Linear issue: ENG-1756

Test Plan

I used vim to search for the RegExp [A-Z] in the list and found no results

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/reserved-usernames

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Sep 7 2022, 8:08 PM

Herald added a subscriber: • abosh. · View Herald TranscriptSep 7 2022, 8:08 PM

Harbormaster completed remote builds in B11975: Diff 16429.Sep 7 2022, 8:18 PM

ashoat requested review of this revision.Sep 7 2022, 8:18 PM

atul accepted this revision.Sep 7 2022, 8:29 PM

This revision is now accepted and ready to land.Sep 7 2022, 8:29 PM

Add comment explaining all entries must be lowercase

This revision was landed with ongoing or failed builds.Sep 8 2022, 7:09 AM

Closed by commit rCOMMb061099f516f: [lib] Lowercase all reserved usernames (authored by ashoat). · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMb061099f516f: [lib] Lowercase all reserved usernames.

Harbormaster completed remote builds in B12018: Diff 16500.Sep 8 2022, 7:18 AM

Revision Contents
Changeset List

Path

Size

lib/

utils/

reserved-users.js

7 lines

Diff 16500

View Options

lib/utils/reserved-users.js

[lib] Lowercase all reserved usernamesClosedPublicActions