[Tunnelbroker] Force finding protobuf config
ClosedPublic
Actions

Authored by • jon on Sep 14 2022, 11:46 AM.

Details

Reviewers

• max
atul

Commits

rCOMM6d11fbc99e67: [Tunnelbroker] Force finding protobuf config

Summary

Headers from homebrew's protobuf were still being found.
Force find_library to find the related cmake CONFIG which should expose the
correct targets instead of just the library

example: https://buildkite.com/comm/tunnelbroker-unittests/builds/3

Test Plan

Tunnelbroker CI passes

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jon created this revision.Sep 14 2022, 11:46 AM

Herald added subscribers: • abosh, tomek, ashoat. · View Herald TranscriptSep 14 2022, 11:46 AM

https://buildkite.com/comm/tunnelbroker-unittests/builds/5#01833d54-b683-4e52-8df1-ceaed0d53d3e is still failing. For some reason /opt/homebrew/include/google/protobuf/message.h is still getting picked up, which sets the PROTOBUF_VERSION, and so when our generated files are consumed, it will cause this to fail:

#if 3015008 < PROTOBUF_MIN_PROTOC_VERSION
#error This file was generated by an older version of protoc which is
#error incompatible with your Protocol Buffer headers. Please
#error regenerate this file with a newer version of protoc.
#endif

Harbormaster completed remote builds in B12150: Diff 16677.Sep 14 2022, 11:56 AM

• jon requested review of this revision.Sep 14 2022, 11:56 AM

atul accepted this revision.Sep 15 2022, 8:36 AM

This revision is now accepted and ready to land.Sep 15 2022, 8:36 AM

Closed by commit rCOMM6d11fbc99e67: [Tunnelbroker] Force finding protobuf config (authored by • jon). · Explain WhySep 19 2022, 12:37 PM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMM6d11fbc99e67: [Tunnelbroker] Force finding protobuf config.