[lib] Show parent thread members before community members
ClosedPublic
Actions

Authored by michal on Sep 16 2022, 2:22 AM.

Details

Reviewers

tomek
atul
• abosh
ashoat

Commits

rCOMM0df8443ef437: [lib] Show parent thread members before community members

Summary

https://linear.app/comm/issue/ENG-1710
When creating a subchannel, members of the parent chat should be listed at the top.

Test Plan

Start creating subchannels and check that there are no users with "not in parent chat" at the top of the list.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Sep 16 2022, 2:22 AM

Herald added a subscriber: ashoat. · View Herald TranscriptSep 16 2022, 2:22 AM

Harbormaster completed remote builds in B12207: Diff 16747.Sep 16 2022, 2:31 AM

michal requested review of this revision.Sep 16 2022, 2:31 AM

I can review this since I am most familiar with the code here. It looks good to me!

This revision is now accepted and ready to land.Sep 16 2022, 7:41 AM

michal added 1 blocking reviewer(s): tomek.Sep 19 2022, 1:35 AM

This revision now requires review to proceed.Sep 19 2022, 1:35 AM

tomek accepted this revision.Sep 20 2022, 10:16 AM

This revision is now accepted and ready to land.Sep 20 2022, 10:16 AM

Closed by commit rCOMM0df8443ef437: [lib] Show parent thread members before community members (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhySep 21 2022, 3:19 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM0df8443ef437: [lib] Show parent thread members before community members.

Revision Contents
Changeset List

Path

Size

lib/

shared/

search-utils.js

23 lines

Diff 16941

View Options

lib/shared/search-utils.js

[lib] Show parent thread members before community membersClosedPublicActions