Page MenuHomePhabricator
Differential D5182

[services] Tunnelbroker - Add `env_logger` to the Rust library
ClosedPublic
Actions

Authored by • max on Sep 19 2022, 3:01 PM.
Tags
None
Referenced Files
F3510487: D5182.id16928.diff
Sat, Dec 21, 12:01 PM
Unknown Object (File)
Tue, Dec 17, 2:53 PM
Unknown Object (File)
Tue, Dec 17, 2:53 PM
Unknown Object (File)
Tue, Dec 17, 2:53 PM
Unknown Object (File)
Tue, Dec 17, 2:50 PM
Unknown Object (File)
Mon, Dec 16, 3:57 AM
Unknown Object (File)
Nov 7 2024, 2:12 AM
Unknown Object (File)
Oct 27 2024, 6:36 PM
View All Files
Subscribers
• abosh
ashoat
atul
• karol
tomek

Details

Reviewers
• jon
tomek
ashoat
Commits
rCOMMa34c0adcca8c: [services] Tunnelbroker - Add `env_logger` to the Rust library
Summary

This diff introduces adding and using of env_logger crate to configure the logging level via environment variables.

We already have the same approach in the backup service (D5124).

Test Plan

Start tunnelbroker with the different logging levels using environment variables.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• max created this revision.Sep 19 2022, 3:01 PM
• max held this revision as a draft.
Herald added a reviewer: • jon. · View Herald TranscriptSep 19 2022, 3:01 PM
Herald added subscribers: • abosh, • karol, atul and 2 others. · View Herald Transcript
Harbormaster completed remote builds in B12292: Diff 16868.Sep 19 2022, 3:15 PM
• max published this revision for review.Sep 19 2022, 3:30 PM
• max retitled this revision from [services] Tunnelbroker - Add env_logger to the Rust library to [services] Tunnelbroker - Add `env_logger` to the Rust library.
• max edited the summary of this revision. (Show Details)
• max edited the test plan for this revision. (Show Details)
• max added a reviewer: tomek. • max added 1 blocking reviewer(s): • jon.
Herald added a reviewer: • karol. · View Herald TranscriptSep 19 2022, 3:31 PM
• jon accepted this revision.Sep 19 2022, 3:41 PM
tomek accepted this revision.Sep 20 2022, 7:26 AM
This revision is now accepted and ready to land.Sep 20 2022, 7:26 AM
• max edited reviewers, added: ashoat; removed: • karol.Sep 20 2022, 10:50 AM
This revision now requires review to proceed.Sep 20 2022, 10:50 AM
• max added a comment.Sep 20 2022, 10:51 AM

Adding @ashoat as a blocking reviewer, because this diff touches dependencies.

ashoat accepted this revision.Sep 20 2022, 11:57 AM
This revision is now accepted and ready to land.Sep 20 2022, 11:57 AM
Closed by commit rCOMMa34c0adcca8c: [services] Tunnelbroker - Add `env_logger` to the Rust library (authored by • max). · Explain WhySep 20 2022, 12:24 PM
This revision was automatically updated to reflect the committed changes.
• max added a commit: rCOMMa34c0adcca8c: [services] Tunnelbroker - Add `env_logger` to the Rust library.

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
rust-notifications/
1 line
src/
9 lines

Diff 16928

View Options

services/tunnelbroker/rust-notifications/Cargo.lock

Loading...
View Options

services/tunnelbroker/rust-notifications/Cargo.toml

Loading...
View Options

services/tunnelbroker/rust-notifications/src/lib.rs

Loading...