Page MenuHomePhabricator

[native] Move tabNavigator listener to useEffect
ClosedPublic

Authored by michal on Sep 21 2022, 4:08 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 9, 11:17 AM
Unknown Object (File)
Thu, Jan 9, 11:17 AM
Unknown Object (File)
Thu, Jan 9, 11:16 AM
Unknown Object (File)
Thu, Jan 9, 11:00 AM
Unknown Object (File)
Sat, Jan 4, 9:11 AM
Unknown Object (File)
Sat, Jan 4, 9:11 AM
Unknown Object (File)
Fri, Jan 3, 4:54 PM
Unknown Object (File)
Fri, Jan 3, 12:43 PM
Subscribers

Details

Summary

ENG-1855, raised in this diff
Moves the code from mount methods to a useEffect in the ConnectedThreadSettings.

Test Plan
  • Open thread settings, click on the profile tab
    • click on the "inbox" tab -> you should return to the thread settings
    • click on the "inbox" tab again -> you should return to the chat list
  • Open thread settings, change some option, click on the "inbox" tab -> you should return to the chat list but only after the change is saved

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable