[native] Remove background option from sidebar settings
ClosedPublic
Actions

Authored by michal on Sep 29 2022, 1:24 AM.

Details

Reviewers

tomek
atul
• abosh
ashoat

Commits

rCOMM0c1762b2b51c: [native] Remove background option from sidebar settings

Summary

Part of ENG-1729
Sidebars are always displayed under their parent chat, so the option of moving them between Focused and Background does nothing and should be removed.

Test Plan

Check if the option is no longer visible in sidebar settings
Check if it's still visible and works correctly in other chats

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Sep 29 2022, 1:24 AM

Herald added a subscriber: ashoat. · View Herald TranscriptSep 29 2022, 1:24 AM

Harbormaster completed remote builds in B12505: Diff 17165.Sep 29 2022, 1:34 AM

michal requested review of this revision.Sep 29 2022, 1:34 AM

ashoat accepted this revision.Sep 29 2022, 7:20 AM

This revision is now accepted and ready to land.Sep 29 2022, 7:20 AM

Rebase on master

Harbormaster completed remote builds in B12543: Diff 17213.Sep 30 2022, 3:21 AM

Closed by commit rCOMM0c1762b2b51c: [native] Remove background option from sidebar settings (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhySep 30 2022, 3:24 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM0c1762b2b51c: [native] Remove background option from sidebar settings.

Revision Contents
Changeset List

Path

Size

native/

chat/

settings/

thread-settings.react.js

12 lines

Diff 17214

View Options

native/chat/settings/thread-settings.react.js

[native] Remove background option from sidebar settingsClosedPublicActions